Repository navigation
My Day: say how old the data is ("Updated 4 min ago") - #3508
Conversation
Ward Flow review item 5, owner approved 12 Oct 2026. The Needs you line reads "Updated just now", then "N min ago" on the minute tick, then the clock time once the data is an hour old. The offline note keeps the clock time it loaded at. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113Rr2NnmLuLKLWdKTwHHqd
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will degrade performance by 23.09%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ |
answer-ranking: rankAnswerEvidence 40 results |
24.8 ms | 32.2 ms | -23.09% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/project-thread-8ygx0b (2945921) with main (69b9ff0)
…ute tick Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113Rr2NnmLuLKLWdKTwHHqd
|
CodSpeed flags Generated by Claude Code |
🤖 CodeAnt AI — Review Status
|
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
PR Summary by QodoShow how recently My Day data was updated
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd32e96f73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Reset data age after every retry - Align age updates with answer time
It bumped the revision when Retry is tapped, not when the sources answer, so the line could say "Updated just now" while the old data was still showing. That makes data look fresher than it is, the unsafe direction. Both findings were answered on the PR and left as they were. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113Rr2NnmLuLKLWdKTwHHqd
|
I've reverted the Qodo Fixer commit (defe3d9) in f3b6298. The branch content is now identical to dd32e96 again. That commit raised the read revision when Retry is tapped, not when the sources answer. So the line could say "Updated just now" while the old data was still on screen, which makes data look fresher than it is. It also computed the age from a render-time Generated by Claude Code |
|
Three tests failed across the CI runs for this PR. I don't think any of them is caused by this PR, because the diff only changes the My Day "Updated … ago" text.
The other 19 of the 21 browser-matrix shards passed, including every Safari and phone shard. PR required was green on f3b6298; the branch has since been brought up to date with main (2945921). CodSpeed on 2945921 reports Production UI (3) on 2945921, Generated by Claude Code |
CodeAnt PR Risk: Low Risk
Assessed commit: |
CI failed: One Playwright responsive-layout test failed: the prescribing search results sat 78px above the expected scroll position over the phone bottom dock (261 other tests passed). The failure is unrelated to this My Day change, so it is most likely a pre-existing layout or assertion issue.OverviewOne unique error template was found across 3 analyzed logs (job 115141050247). The run had 261 Playwright tests passing and 1 failing, so the overall assessment is a single, isolated UI test failure that does not appear to be caused by this PR. FailuresPrescribing search results overlap phone bottom dock (confidence: high)
Summary
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · Changing My Day freshness timestamps could mislead users about how current needs data is if answer-time tracking diverges from loaded content. Adds a relative age to My Day's Needs you line, so it reads "Updated just now", then "Updated 4 min ago" as minutes pass, and "Updated at 14:05" once data is an hour old. The load moment now records when sources actually answered, which resolves the finding that the age could read up to a minute too old. No open issues found. ✅ 1 closed✅ Edge Case: Load moment uses the minute-tick clock, so the age reads up to a minute too old
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
* My Day: show the date with the clock time in 'Updated at' once data is an hour old Follow-up to #3508 (owner-approved request): past the hour, 'Updated at 14:05' now reads 'Updated at 14:05, Tue 13 Oct' so yesterday's data isn't mistaken for today's. Dated on the work-zone calendar. * My Day: take the 'Updated at' time and date from the same instant and zone * My Day: format the hour-old 'Updated at' in the page's work zone --------- Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
User description
Requested by Josh · project thread
Summary
Before: My Day's Needs you line said "Checked 14:05 · On Call, Roster". The reader had to work out how old that was.
After: the line says "Updated just now", then "Updated 4 min ago" as the minute ticks, then "Updated at 14:05" once the data is an hour old. The coloured dot and the list of areas are unchanged, and the full "All N" list uses the same words. The offline note keeps the clock time it loaded at.
This is Ward Flow review item 5, which the owner approved on 12 Oct 2026 and confirmed again on 13 Oct ("go ahead with all recommendations"). The other Ward Flow items shipped in #3489.
How: the page now records the moment the sources last answered, beside the existing clock string. A new helper,
myDayUpdatedAgo, turns that moment into words on the page's existing one-minute tick. The dashboard, the Needs you card and the full list take the phrase as an optionalupdatedprop, and fall back to the clock time when it is missing.Areas touched: Personal practice
Verification
npm run test:focusedon the changed My Day files and the new helper test gaveTest Files 47 passed (47)andTests 617 passed (617).tsc --noEmitran clean.Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_0113Rr2NnmLuLKLWdKTwHHqd
Generated by Claude Code
Summary by cubic
My Day now says how old its data is instead of only showing the clock time when it was checked.
atMs, so the age stays exact even when the minute tick is stale, and aligns the age tick to that moment.updatedprop through the dashboard, Needs you card, and full list, falling back to the clock time when the moment is missing.Implements Ward Flow review item 5, approved 12 Oct 2026. Low risk: it changes the text of one line only, with no layout change.
Written for commit 2945921. Summary will update on new commits.
CodeAnt-AI Description
Show how recently My Day data was updated
What Changed
Impact
✅ See My Day data freshness at a glance✅ Track update age minute by minute✅ Keep the clock time for data older than an hour💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.