Repository navigation
My Day: show the date with the time in 'Updated at' - #3530
Conversation
…s an hour old Follow-up to #3508 (owner-approved request): past the hour, 'Updated at 14:05' now reads 'Updated at 14:05, Tue 13 Oct' so yesterday's data isn't mistaken for today's. Dated on the work-zone calendar.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 20 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Summary by CodeRabbit
WalkthroughFor updates at least an hour old, ChangesUpdate age display
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to
|
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will not alter performance
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: faa21b25ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CodeAnt Nitpicks1 code suggestion1. If the work-time zone changes after sources answer,
|
CodeAnt PR Risk: Low Risk
Assessed commit: |
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
|
Code review by qodo was updated up to the latest commit 354d173 |
Stale: every review thread on #3530 is resolved and all required checks are green (owner-approved dismissal of coderabbitai CHANGES_REQUESTED).
Code Review ✅ Approved🟡 Medium risk · Changing My Day’s hour-old update label to derive time and date from the work zone could show a misleading freshness date if conversion is wrong. Adds the date to the My Day 'Updated at' label once data is an hour old, so VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
User description
Follow-up to #3508 (owner-approved request to show the date, not only the time, in the 'Updated at' display).
myDayUpdatedAgo(src/components/my-day/my-day-page-parts.tsx): once the data is an hour old,Updated at 14:05now readsUpdated at 14:05, Tue 13 Oct, dated on the work-zone (Perth default) calendar viaperthDateOf+formatPerthDay. "just now" / "N min ago" are unchanged.Local: vitest (my-day-updated-ago, my-day-page.dom) 43/43, eslint, prettier pass. Full typecheck left to CI (local push guard skipped it because another heavy run held the coordinator).
Summary by cubic
Follow-up to #3508: once My Day data is an hour old, "Updated at 14:05" now reads "Updated at 14:05, Tue 13 Oct" so yesterday's data isn't mistaken for today's. Both time and date are derived from the recorded moment in the work zone the page passes in (
myDayUpdatedAgotakes the zone with a Perth default), so an earlier clock string can't introduce a mismatch. "just now" and "N min ago" are unchanged.Bug Fixes
Written for commit c5644a3. Summary will update on new commits.
CodeAnt-AI Description
Show the date and work-zone time for older My Day updates
What Changed
Impact
✅ Clearer dates for yesterday’s My Day data✅ Consistent update times across work zones✅ Reliable labels when earlier clock text is unavailable💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.