Skip to content

test(webkit): wait for the Forms composer to be live before typing - #3503

Merged
gitar-bot[bot] merged 1 commit into
mainfrom
claude/webkit-forms-enter-w72vlz
Oct 12, 2026
Merged

gitar-bot[bot] merged 1 commit into
mainfrom
claude/webkit-forms-enter-w72vlz

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

User description

Summary

  • Before: main's Safari release matrix after test(webkit): retry the patient panel tap and report the Dictionary label layout #3502 had one failure left. The installed-app (mobile-pwa-standalone) test "keeps compact codes literal and uses the ordinary Forms result route" typed into the Forms home and pressed Enter straight after loading, before React had attached the composer's handlers. The search never submitted and the page stayed on the Forms home.

  • After: the test waits until the composer's change and submit handlers are attached, exactly as the Smart search test above it already did. That wait is now one shared helper used by both tests.

  • Both test(webkit): retry the patient panel tap and report the Dictionary label layout #3502 fixes passed on main (installed-app QTc and the phone Dictionary label); this is the only remaining release-matrix failure from main run 38291430591.

  • Test-only. No test skipped, no assertion loosened, no app code changed.

Verification

  • Checks run: prettier --check ("All matched files use Prettier code style!"), eslint and tsc --noEmit on the changed file, all clean.
  • WebKit cannot run in this container, so the WebKit proof is main's next release browser matrix. The PR's own browser jobs cover Chromium.

Risk and rollout

  • Risk: none to the app; test timing only.
  • Rollback: revert this commit.
  • Provider or production effects: None.

Notes

  • Ledger: #9Z197J.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr


Generated by Claude Code


Summary by cubic

Fixes a WebKit-only flake where the Forms installed-app test typed before React attached the composer's handlers, so the search never submitted.

Extracts the handler wait into a shared helper used by both the existing Smart search test and the Forms test. Test-only; no app code changed, no test skipped or loosened.

Written for commit 609e9dc. Summary will update on new commits.

View guided diff Turn on auto-fix


CodeAnt-AI Description

Stabilize the WebKit Forms search test

What Changed

  • The Forms search test now waits until typing and submitting are ready before entering a query, preventing lost input on slower browsers.
  • The Smart search tests use the same readiness check.

Impact

✅ Fewer intermittent WebKit Forms test failures

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Main's Safari matrix after #3502 had one failure left: the installed-app
"compact codes literal" test typed and pressed Enter straight after loading
the Forms home, before React had attached the composer's handlers, so the
search never submitted. The test above it already waited for those handlers;
that wait is now a shared helper and this test uses it too.

No test skipped or loosened; no app code changed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr
@codeant-ai

codeant-ai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 609e9dc Oct 12, 2026 · 19:35 19:39

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@codeant-ai

codeant-ai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T19:39:13.183582Z 609e9dc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9e4605fc-e1fe-4f4b-bd94-4e6d398c4b75

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@supabase

supabase Bot commented Oct 12, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Oct 12, 2026
@codeant-ai

codeant-ai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🏁 CodeAnt Quality Gate Results

Commit: 609e9dc8
Scan Time: 2026-10-12 19:49:42 UTC

✅ Overall Status: PASSED

Quality Gate Details

Quality Gate Status Details
Secrets ✅ PASSED 0 secrets found
Duplicate Code ✅ PASSED 0.0% duplicated
SAST ✅ PASSED No security issues
Bugs ✅ PASSED Rating S: No bugs
IAC ✅ PASSED No IAC issues

View Full Results

@gitar-bot

gitar-bot Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor
Code Review ✅ Approved

🟢 Low risk · Extracting the React handler readiness wait and applying it to the Forms browser test changes test synchronization only, not application behavior.

Test-only change that waits for the Forms composer's change and submit handlers to attach before typing, using a shared helper also used by the Smart search test. No issues found.

Auto-approved: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria.

Review coverage

🤖 Auto-approval Approved

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot
gitar-bot Bot enabled auto-merge (squash) October 12, 2026 19:36

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Wait for Forms composer handlers before WebKit test input

🧪 Tests 🐞 Bug fix 🕐 10-20 Minutes

Grey Divider

AI Description

• Prevent the Forms installed-app test from typing before React can handle input and submission.
• Share the existing handler-readiness wait with the Smart search test without changing assertions
 or app code.
Diagram

graph TD
  A["Smart and Forms tests"] --> B["Readiness helper"] --> C{"Input handler ready?"} --> D{"Form handler ready?"} --> E["Fill and submit"] --> F["Route assertions"]
Loading
High-Level Assessment

Reusing the existing handler-specific wait is appropriate for this test-only race. A generic hydration wait would confirm React attached to the elements, but not that the required change and submit handlers are callable.

Files changed (1) +24 / -15

Tests (1) +24 / -15
ui-clinical-ask.spec.tsShare composer handler wait with Forms route test +24/-15

Share composer handler wait with Forms route test

• Extracts the Smart search test's visibility and React onChange/onSubmit polling into a helper. The compact-code Forms test now waits for those handlers before filling and submitting; its route and request assertions are unchanged.

tests/ui-clinical-ask.spec.ts

@codspeed

codspeed Bot commented Oct 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 8 untouched benchmarks


Comparing claude/webkit-forms-enter-w72vlz (609e9dc) with main (e31c11d)

Open in CodSpeed

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

@codeant-ai

codeant-ai Bot commented Oct 12, 2026

Copy link
Copy Markdown

CodeAnt Nitpicks

1 code suggestion

1. These polls inherit the 10-second global expect timeout, so WebKit hydration taking 10–15 seconds fails this test even though sibling handler probes wait 15 seconds.

Possible bug · tests/ui-clinical-ask.spec.ts:54-62

@codeant-ai

codeant-ai Bot commented Oct 12, 2026

Copy link
Copy Markdown

CodeAnt PR Risk: Low Risk

  • The PR appears safe to merge; it only refactors test synchronization and applies it to the Forms search test.
  • No application behavior changes or unresolved concerns are shown in the supplied diff.

Assessed commit: 609e9dc8322e

@gitar-bot
gitar-bot Bot merged commit 351bd43 into main Oct 12, 2026
46 of 48 checks passed
@gitar-bot
gitar-bot Bot deleted the claude/webkit-forms-enter-w72vlz branch October 12, 2026 19:48
gitar-bot Bot pushed a commit that referenced this pull request Oct 12, 2026
…ing Enter (#3504)

Main's Safari matrix after #3503 cleared the Forms test and showed one new
intermittent failure: the installed-app DSM category facet test focused the
filter button and pressed Enter straight after load, before React attached
its handler, so the filter panel never opened. Wait for hydration first, the
same fix as #3503.

No test skipped or loosened; no app code changed.


Claude-Session: https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files 🟡 Small blast radius 🕐 10-20 Minutes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants