Repository navigation
test(webkit): wait for the Forms composer to be live before typing - #3503
Conversation
Main's Safari matrix after #3502 had one failure left: the installed-app "compact codes literal" test typed and pressed Enter straight after loading the Forms home, before React had attached the composer's handlers, so the search never submitted. The test above it already waited for those handlers; that wait is now a shared helper and this test uses it too. No test skipped or loosened; no app code changed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr
🤖 CodeAnt AI — Review Status
|
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Code Review ✅ Approved🟢 Low risk · Extracting the React handler readiness wait and applying it to the Forms browser test changes test synchronization only, not application behavior. Test-only change that waits for the Forms composer's change and submit handlers to attach before typing, using a shared helper also used by the Smart search test. No issues found.
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
PR Summary by QodoWait for Forms composer handlers before WebKit test input
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Merging this PR will not alter performance
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab) |
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
CodeAnt Nitpicks1 code suggestion1. These polls inherit the 10-second global expect timeout, so WebKit hydration taking 10–15 seconds fails this test even though sibling handler probes wait 15 seconds.Possible bug · |
CodeAnt PR Risk: Low Risk
Assessed commit: |
…ing Enter (#3504) Main's Safari matrix after #3503 cleared the Forms test and showed one new intermittent failure: the installed-app DSM category facet test focused the filter button and pressed Enter straight after load, before React attached its handler, so the filter panel never opened. Wait for hydration first, the same fix as #3503. No test skipped or loosened; no app code changed. Claude-Session: https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr Co-authored-by: Claude <noreply@anthropic.com>
User description
Summary
Before: main's Safari release matrix after test(webkit): retry the patient panel tap and report the Dictionary label layout #3502 had one failure left. The installed-app (
mobile-pwa-standalone) test "keeps compact codes literal and uses the ordinary Forms result route" typed into the Forms home and pressed Enter straight after loading, before React had attached the composer's handlers. The search never submitted and the page stayed on the Forms home.After: the test waits until the composer's change and submit handlers are attached, exactly as the Smart search test above it already did. That wait is now one shared helper used by both tests.
Both test(webkit): retry the patient panel tap and report the Dictionary label layout #3502 fixes passed on main (installed-app QTc and the phone Dictionary label); this is the only remaining release-matrix failure from main run 38291430591.
Test-only. No test skipped, no assertion loosened, no app code changed.
Verification
prettier --check("All matched files use Prettier code style!"),eslintandtsc --noEmiton the changed file, all clean.Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr
Generated by Claude Code
Summary by cubic
Fixes a WebKit-only flake where the Forms installed-app test typed before React attached the composer's handlers, so the search never submitted.
Extracts the handler wait into a shared helper used by both the existing Smart search test and the Forms test. Test-only; no app code changed, no test skipped or loosened.
Written for commit 609e9dc. Summary will update on new commits.
CodeAnt-AI Description
Stabilize the WebKit Forms search test
What Changed
Impact
✅ Fewer intermittent WebKit Forms test failures💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.