test(webkit): wait for the DSM filter trigger to hydrate before pressing Enter by BigSimmo · Pull Request #3504 · BigSimmo/PsychSift

BigSimmo · 2026-10-12T20:43:55Z

User description

Summary

Before: main's Safari release matrix after test(webkit): wait for the Forms composer to be live before typing #3503 (run 38300091965) cleared the Forms test and showed one new intermittent failure. The installed-app (mobile-pwa-standalone) test "DSM category facets support keyboard selection and restore focus" focused the filter button and pressed Enter straight after load, before React had attached its handler. The filter panel never opened. The same test passed in the previous main run, which fits a timing race.
After: the test waits for the trigger to hydrate with the shared expectHydrated helper before focusing it. This is the same pattern as test(webkit): wait for the Forms composer to be live before typing #3503.
Test-only. No test skipped, no assertion loosened, no app code changed.

Verification

Checks run: prettier --check ("All matched files use Prettier code style!") and eslint on the changed file, both clean.
WebKit can't run in this container, so main's next release browser matrix is the WebKit proof.

Risk and rollout

Risk: none to the app. This only changes test timing.
Rollback: revert this commit.
Provider or production effects: None.

Notes

Ledger: #9Z197J.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr

Generated by Claude Code

Summary by cubic

Fixes an intermittent WebKit failure in the DSM category facet test by waiting for the filter trigger to hydrate before pressing Enter.

Main's Safari matrix showed the installed-app test pressing Enter before React attached the trigger's handler, so the filter panel never opened. The test now uses the shared expectHydrated helper before focusing, matching the fix from #3503. Test-only change — no test skipped, no assertion loosened, no app code touched.

^{Written for commit f3aef43. Summary will update on new commits.}

CodeAnt-AI Description

Stabilize keyboard selection in the DSM filter test

What Changed

The DSM category filter test now waits for the filter trigger to be ready before pressing Enter, preventing missed keypresses on slower browsers.

Impact

✅ Fewer intermittent WebKit test failures
✅ More reliable DSM keyboard-selection coverage

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

…ing Enter Main's Safari matrix after #3503 cleared the Forms test and showed one new intermittent failure: the installed-app DSM category facet test focused the filter button and pressed Enter straight after load, before React attached its handler, so the filter panel never opened. Wait for hydration first, the same fix as #3503. No test skipped or loosened; no app code changed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr

supabase · 2026-10-12T20:44:01Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

greptile-apps

BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

codeant-ai · 2026-10-12T20:44:04Z

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	`f3aef43`	Oct 12, 2026 · 20:44	20:44

codeant-ai · 2026-10-12T20:44:05Z

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

chatgpt-codex-connector · 2026-10-12T20:44:06Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-12T20:46:15.066713Z	`f3aef43`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-12T20:44:06Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 2c02492a-034d-4dc4-8ec3-a9e47336df39

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

claude · 2026-10-12T20:44:15Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

codeant-ai · 2026-10-12T20:44:37Z

🏁 CodeAnt Quality Gate Results

Commit: f3aef435
Scan Time: 2026-10-12 20:59:41 UTC

✅ Overall Status: PASSED

Quality Gate Details

Quality Gate	Status	Details
Secrets	✅ PASSED	0 secrets found
Duplicate Code	✅ PASSED	0.0% duplicated
SAST	✅ PASSED	No security issues
Bugs	✅ PASSED	Rating S: No bugs
IAC	✅ PASSED	No IAC issues

View Full Results

qodo-code-review · 2026-10-12T20:44:40Z

PR Summary by Qodo

Wait for DSM filter hydration before WebKit keyboard interaction

🐞 Bug fix 🧪 Tests 🕐 Less than 10 minutes

AI Description

• Wait for the DSM filter trigger to hydrate before pressing Enter, preventing a WebKit timing race.
• Preserve the test’s keyboard-selection and focus-restoration assertions without changing app code.

Diagram

graph TD
  A["DSM filter trigger"] --> B["Hydration wait"] --> C["Focus and Enter"] --> D["Filter panel"]

High-Level Assessment

Using the existing per-element hydration helper directly before the keypress addresses the race without changing production behavior or weakening the test. A fixed delay would be less reliable.

Files changed (1) +3 / -0

Tests (1) +3 / -0

ui-smoke.spec.tsWait for the DSM filter trigger to hydrate +3/-0

Wait for the DSM filter trigger to hydrate

• Imports the shared expectHydrated helper and awaits trigger hydration before focusing it and pressing Enter. The remaining panel, keyboard-selection, and focus-restoration assertions are unchanged.

tests/ui-smoke.spec.ts

codeant-ai · 2026-10-12T20:45:01Z

CodeAnt PR Risk: Low Risk

The PR appears safe to merge; it waits for the category-filter trigger to hydrate before keyboard interaction in the smoke test.

Assessed commit: f3aef435cdbf

gitar-bot · 2026-10-12T20:45:03Z

Code Review ✅ Approved

🟢 Low risk · Adding a hydration wait in one WebKit UI test changes only test synchronization, leaving application behavior and interfaces untouched.

Test-only change that makes the DSM category facet keyboard test wait for the filter trigger to hydrate via expectHydrated before focusing and pressing Enter, addressing the intermittent WebKit race where the panel never opened. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Approved

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

gitar-bot

Gitar has auto-approved this PR (configure)

codspeed · 2026-10-12T20:45:22Z

Merging this PR will not alter performance

⚠️

2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

chunking: chunkTextWithOverlap long document

catalog-search: rankCatalogRecords 400 records

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

medication-entities: medicationEntityMatchesInText

✅ 8 untouched benchmarks

_{Comparing claude/webkit-dsm-facet-w72vlz (f3aef43) with main (351bd43)}

qodo-code-review · 2026-10-12T20:45:42Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

qodo-code-review · 2026-10-12T20:45:47Z

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

WebKit now runs in CI and its genuine failures were fixed test-side in #3492-#3494 and #3501-#3504. The last three were the same race, a keypress before React attached the handler; the update names the helper to use and the one check left (the first main run after #3504). Claude-Session: https://claude.ai/code/session_01DCghuougzFFXRF3dQQEcYr Co-authored-by: Claude <noreply@anthropic.com>

greptile-apps Bot reviewed Oct 12, 2026

View reviewed changes

codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Oct 12, 2026

qodo-code-review Bot added the 🕐 Less than 10 minutes label Oct 12, 2026

gitar-bot Bot enabled auto-merge (squash) October 12, 2026 20:45

gitar-bot Bot approved these changes Oct 12, 2026

View reviewed changes

qodo-code-review Bot added the 🟡 Small blast radius label Oct 12, 2026

gitar-bot Bot merged commit ac737f1 into main Oct 12, 2026
49 checks passed

gitar-bot Bot deleted the claude/webkit-dsm-facet-w72vlz branch October 12, 2026 20:59

BigSimmo mentioned this pull request Oct 12, 2026

docs(ledger): record the 2026-10-12 Safari fixes on #9Z197J #3505

Merged

1 task done

Conversation

BigSimmo commented Oct 12, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Summary

Verification

Risk and rollout

Notes

Summary by cubic

CodeAnt-AI Description

What Changed

Impact

Checking Your Pull Request

Talking to CodeAnt AI

Example

Preserve Org Learnings with CodeAnt

Example

Retrigger review

Check Your Repository Health

Uh oh!

supabase Bot commented Oct 12, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codeant-ai Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CodeAnt AI — Review Status

Uh oh!

codeant-ai Bot commented Oct 12, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

chatgpt-codex-connector Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 12, 2026

Uh oh!

claude Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codeant-ai Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🏁 CodeAnt Quality Gate Results

✅ Overall Status: PASSED

Quality Gate Details

Uh oh!

qodo-code-review Bot commented Oct 12, 2026

PR Summary by Qodo

Uh oh!

codeant-ai Bot commented Oct 12, 2026

CodeAnt PR Risk: Low Risk

Uh oh!

gitar-bot Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitar-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed Bot commented Oct 12, 2026

Merging this PR will not alter performance

Uh oh!

qodo-code-review Bot commented Oct 12, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

qodo-code-review Bot commented Oct 12, 2026

Qodo Fixer

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BigSimmo commented Oct 12, 2026 •

edited by cubic-dev-ai Bot

Loading

codeant-ai Bot commented Oct 12, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 12, 2026 •

edited

Loading

claude Bot commented Oct 12, 2026 •

edited

Loading

codeant-ai Bot commented Oct 12, 2026 •

edited

Loading

gitar-bot Bot commented Oct 12, 2026 •

edited

Loading