Skip to content

chore(ci-compliance): use public fixture names in the upgrade-map tests #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakanni wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore(ci-compliance): use public fixture names in the upgrade-map tests #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tools/ComplianceRunner/tests/Compliance.Unit.Tests/Unit/FileFilterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ public class IsDatasetFileTests
[TestCase("DataSets/foo.json", ExpectedResult = true)] // root-level, mixed case
[TestCase("DataSets/LCA/deep/x.json", ExpectedResult = true)] // root-level, nested

// Versioning upgrade maps. The live case is a project directory supplying the
// "datasets" substring, which is how BuroHappold_Datasets/Versioning_93.json and
// BHoM_Datasets/Versioning_100.json get selected at all.
// Versioning upgrade maps. A project directory supplying the "datasets" substring is
// the only way a file named like this is selected at all, and BHoM_Datasets has that
// layout: one .csproj in a directory whose name carries the substring.
[TestCase("BHoM_Datasets/Versioning_93.json", ExpectedResult = false)]
[TestCase("BHoM_Datasets/Versioning_100.json", ExpectedResult = false)]
[TestCase(@"BHoM_Datasets\Versioning_93.json", ExpectedResult = false)] // backslash separators
Expand Down Expand Up @@ -77,8 +77,8 @@ public bool IsDatasetFile(string file)
// The upgrade-map rule on its own, so a failure says which of the two predicates moved.
// These paths carry no "datasets" substring, so IsDatasetFile rejects them anyway and
// could not distinguish the two.
[TestCase("Tagging_oM/Versioning_93.json", ExpectedResult = true)]
[TestCase("Tagging_oM/Versioning_Rules.json", ExpectedResult = false)]
[TestCase("Structure_oM/Versioning_93.json", ExpectedResult = true)]
[TestCase("Structure_oM/Versioning_Rules.json", ExpectedResult = false)]
[TestCase("Versioning_93.json", ExpectedResult = true)] // no directory at all
[TestCase("Structure_oM/Versioning_93.txt", ExpectedResult = true)] // extension is IsDatasetFile's job
public bool IsVersioningUpgradeMap(string file)
Expand Down
Loading