Conversation
Three fixtures and one comment added in #23 named private repositories: a comment naming a private repository's upgrade map, and two test cases under a private repository's oM project directory. Each name is a literal project directory in a repository that is private, so a path search on it returns that repository alone. Substituted for BHoM_Datasets, which has the layout the comment describes and is public, and Structure_oM, which is public and already used two lines below in the same block. The assertions are unchanged in shape and count: these paths carry no "datasets" substring, so they exercise the upgrade-map predicate on its own exactly as before. 88 unit tests and 66 integration tests pass, unchanged from before the substitution.
sakanni
marked this pull request as ready for review
September 29, 2026 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Three fixtures and one comment added in #23 named private repositories. Each is a literal project directory in a repository that is private, so a path search on it returns that repository and nothing else, and this repository is public.
Substituted for
BHoM_Datasets, which has the layout the comment describes and is public, andStructure_oM, which is public and already used two lines below in the same block.Test files
FileFilterTests, 88 passing, unchanged from before the substitution. The assertions keep their shape and count: these paths carry nodatasetssubstring, so they exercise the upgrade-map predicate on its own exactly as before.Changelog
No behaviour change. Test fixture and comment names only.
Additional comments
The names remain in this repository's history and that cannot be undone. The exposure is stopped going forward rather than erased.