Skip to content

My Jetpack: Show unavailable features and their reasons - #53308

Draft
LiamSarsfield wants to merge 16 commits into
fm/mj-offline-entryfrom
fm/mj-unavailable-features
Draft

My Jetpack: Show unavailable features and their reasons#53308
LiamSarsfield wants to merge 16 commits into
fm/mj-offline-entryfrom
fm/mj-unavailable-features

Conversation

@LiamSarsfield

@LiamSarsfield LiamSarsfield commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes JETPACK-2917

Proposed changes

Show unavailable reasons. Keep toolbar controls together at 1440.

Connected free adds Ads/WooCommerce Analytics. Without a connected owner, seven features show Unavailable with "Requires a connected WordPress.com account"; Social and Backup keep their plugin controls with a module note.

Preserve host/network rules; offline stays default-off.

Related product discussion/links

Parent.

Does this pull request change what data or activity we track or use?

Filter events include available.

Testing instructions

  1. Connected free, no WooCommerce: Features adds WooCommerce Analytics/Ads with reasons, no switches.
  2. Choose Available or search; reload. Choices persist.
  3. Search without its plugin retains Install, Upgrade and plans.
  4. Force Forms off with jetpack_active_modules: All retains it; Available excludes it. Check multisite/hidden modules.
  5. Offline, add add_filter( 'jetpack_my_jetpack_offline_features', '__return_true' );. Unavailable rows cannot be bulk-selected.
  6. At 1440, expand the admin menu: toolbar controls share one row.

Not verified

Connected-owner routes need a final hosted check.

Screenshots

Earlier toolbar emulation.

Connected:

View Before After
grid 1280 Before After
grid 1440 Before After
grid 1920 Before After
grid 390 Before After
list 1280 Before After
list 1440 Before After
list 1920 Before After
list 390 Before After

Offline:

View Before After
grid 1280 Before After
grid 1440 Before After
list 1280 Before After
list 1440 Before After

Forced off Forms:

View Before After
Available 1440 Before After

Earlier connected free comparison.

View Before After Caption
grid 1440 Before After Available added; desktop layout wrapped.
grid 390 Before After All count 47 → 49; layout unchanged.
list 1440 Before After Available added; desktop layout wrapped.
list 390 Before After All count 47 → 49; layout unchanged.

@LiamSarsfield
LiamSarsfield requested a review from a team as a code owner October 7, 2026 15:49
@github-actions

github-actions Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fm/mj-unavailable-features branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fm/mj-unavailable-features

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Package] My Jetpack [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Stats Data [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Tests] Includes Tests Docs labels Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Stats Data plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 7, 2026
@LiamSarsfield LiamSarsfield changed the title feat(my-jetpack): show unavailable features and add an Available filter My Jetpack: Show unavailable features and their reasons Oct 7, 2026
@LiamSarsfield
LiamSarsfield marked this pull request as draft October 7, 2026 15:52
@jp-launch-control

jp-launch-control Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Code Coverage Summary

No summary data is available for parent commit 4bc24c8, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 4bc24c8 is available.

Full summary · PHP report · JS report

@LiamSarsfield LiamSarsfield changed the title My Jetpack: Show unavailable features and their reasons feat(my-jetpack): show unavailable features and add an available filter Oct 8, 2026
@LiamSarsfield LiamSarsfield changed the title feat(my-jetpack): show unavailable features and add an available filter My Jetpack: Show unavailable features and their reasons Oct 8, 2026
@LiamSarsfield LiamSarsfield changed the title My Jetpack: Show unavailable features and their reasons feat(my-jetpack): show unavailable features and add availability filtering Oct 8, 2026
@LiamSarsfield LiamSarsfield changed the title feat(my-jetpack): show unavailable features and add availability filtering feat(my-jetpack): show unavailable features and add Available filter Oct 8, 2026
@LiamSarsfield LiamSarsfield changed the title feat(my-jetpack): show unavailable features and add Available filter My Jetpack: Show unavailable features and their reasons Oct 8, 2026
LiamSarsfield
LiamSarsfield commented Oct 8, 2026
View reviewed changes
Comment thread ...cts/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/features/module-availability.ts
const { control } = state;
return (
! state.pending &&
( control.kind !== 'module' || control.module.override !== 'inactive' ) &&

@LiamSarsfield LiamSarsfield Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Available lists only what can be switched on here, so a module or plugin the host forces off drops out of it, while its card keeps its usual label and the host's reason stays in the details window.

LiamSarsfield
LiamSarsfield commented Oct 8, 2026
View reviewed changes
Comment thread projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/features/toolbar.tsx
onChange={ onSearchChange }
aria-label={ __( 'Search features', 'jetpack-my-jetpack' ) }
placeholder={ __( 'Search features', 'jetpack-my-jetpack' ) }
placeholder={ __( 'Search', 'jetpack-my-jetpack' ) }

@LiamSarsfield LiamSarsfield Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visible placeholder is shorter so it fits the narrower search box beside the filter pills; the field's accessible name stays "Search features".

LiamSarsfield
LiamSarsfield commented Oct 8, 2026
View reviewed changes
Comment thread projects/packages/my-jetpack/_inc/components/my-jetpack-tab-panel/features/styles.module.scss
margin-inline-start: auto;
max-inline-size: 16rem;
min-inline-size: 12rem;
min-inline-size: 8rem;

@LiamSarsfield LiamSarsfield Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search can shrink to 8rem so the filter pills, search and layout buttons share one row in the page's capped content column; below 57rem the pills give way to the select and the search gets its 12rem minimum back.

This was referenced Oct 9, 2026
Draft
Draft

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs [Package] My Jetpack [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Stats Data [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Tests] Includes Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LiamSarsfield