My Jetpack: Fix Features loading and visibility, and connection screen scrolling

[LiamSarsfield]

Proposed changes

• Hold Available's empty state while modules load.
• Hide legacy Custom Content Types, matching the classic Modules list.
• Make the Connect button and footer reachable on shorter screens.
• Clarify a return-value comment and tidy changelog whitespace.

Related product discussion/links

Stacked on #53308; held draft until it lands.

Does this pull request change what data or activity we track or use?

No new data. Loading no longer emits a premature empty-state view.

Testing instructions

1. On a disposable Jetpack site, add these temporary filters:

add_filter( 'jetpack_my_jetpack_feature_visibility', function ( $states ) {
    return $states + array_fill_keys( array( 'akismet', 'anti-spam', 'boost', 'crm', 'protect' ), 'hidden' );
} );
add_filter( 'rest_pre_dispatch', function ( $result, $server, $request ) {
    if ( '/jetpack/v4/module/all' === $request->get_route() ) { sleep( 4 ); }
    return $result;
}, 10, 3 );

2. Reload wp-admin/admin.php?page=my-jetpack#/features?filter=available: no empty message during loading; features appear afterwards. Previously “No features found.” flashed.
3. Remove filters. Search Features for Custom Content Types: no legacy row. The classic Modules list already hides it.
4. With a site-only connection, open #/connection at 1440×900 and 390×650. Scroll or Tab: the Connect button and footer should be reachable; previously clipped.

Screenshots

Before and after each fix on a disposable WordPress site, at 1440×650 and 390×650.

Available loading, 1440px

Before	After

Available loading, 390px

Before	After

Custom Content Types, 1440px

Before	After

Custom Content Types, 390px

Before	After

Connection screen, 1440px

Before	After

Connection screen, 390px

Before	After

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fm/mj-cycle-followups branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fm/mj-cycle-followups

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Backup plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Search plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Videopress plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Stats Data plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

No summary data is available for parent commit 66ee2ed, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 66ee2ed is available.

Full summary · PHP report · JS report