Repository navigation
refactor(php-transformer): move custom wrapper convention recognition into Elements/CustomWrapperConventions - #5280
Open
chubes4 wants to merge 1 commit into
Conversation
… into Elements/CustomWrapperConventions Moves isWrapperConventionTag, authorDataAttributeSelectors, authorAttributeSelectorAddresses and their two helpers, with the two convention constants, out of HtmlCompilation verbatim. unwrapRenderNeutralCustomElements stays: it owns the retained-hook state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4368 (slice 2aa). Stacked on #5276, which is stacked on #5275.
What
Elements/CustomWrapperConventions. It recognizes custom element tags used as a wrapping convention rather than as component hosts. Moved verbatim out ofHtmlCompilation:isWrapperConventionTag,authorDataAttributeSelectors,authorAttributeSelectorAddresses.customElementCssIsRenderNeutral,wrappedContentShape.WRAPPER_CONVENTION_MIN_INSTANCESandWRAPPER_CONTENT_SHAPE_DEPTHconstants.unwrapRenderNeutralCustomElementsremains inHtmlCompilationbecause it owns the run's retained-hook state.StyleResolver.HtmlCompilation: 6914 → 6776 lines.Verification
GATE=0.6be9dd88vs this branch7c1351b8, with HEADs asserted:output_sha25649442575…9377on all 4 outputs, byte-identical.AI disclosure: Claude Opus (Anthropic) via Pi/Roadie moved the code with a mechanical mover script, ran the Lab gate and A/B, and wrote this PR for Chris Huber.