Repository navigation
refactor(php-transformer): move empty visual spacer lowering into Elements/EmptyVisualSpacerLowering - #5283
Open
chubes4 wants to merge 1 commit into
Open
refactor(php-transformer): move empty visual spacer lowering into Elements/EmptyVisualSpacerLowering#5283chubes4 wants to merge 1 commit into
chubes4 wants to merge 1 commit into
Conversation
…ments/EmptyVisualSpacerLowering Moves emptyVisualSpacerBlock, emptyVisualElementAttributes and hasEmptyGridTrackDescendant, with the two private flex-item class constants, out of HtmlCompilation verbatim. The public empty-group class names are read through HtmlTransformer, as the style projectors already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4368 (slice 2ab). Stacked on #5280.
What
Elements/EmptyVisualSpacerLowering. MovesemptyVisualSpacerBlock,emptyVisualElementAttributesandhasEmptyGridTrackDescendantverbatim out ofHtmlCompilation, along with the two private flex-item class constants. It lowers an empty source element that still occupies visual space into a spacer, or an empty group that keeps its box.SourceDom::childElementCountandSourceDom::mergeClassNamesreplace the trait forwards.$this->blocks->createBlock.$this->tree->children()for the one recursion.EMPTY_VISUAL_GROUP_CLASSandEMPTY_RUNTIME_TARGET_CLASSstay where they are. The moved code reads them throughHtmlTransformer::, asNavigationStyleProjectoralready does.HtmlCompilation: 6776 → 6661 lines.Verification
GATE=0.7c1351b8vs this brancheec706f2, with HEADs asserted:output_sha25649442575…9377on all 4 outputs, byte-identical.AI disclosure: Claude Opus (Anthropic) via Pi/Roadie moved the code with a mechanical mover script, ran the Lab gate and A/B, and wrote this PR for Chris Huber.