Repository navigation
refactor(php-transformer): move inert element recognition into Elements/InertElements - #5275
Merged
Merged
Conversation
…ts/InertElements Moves isInertRuntimeMediaPlaceholder, isInertHiddenSvgStorage and hiddenSvgStoreHasNonSvgConsumer out of HtmlCompilation verbatim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4368 (slice 2y).
What
Elements/InertElements. It recognizes source elements that are inert on the page. Moved verbatim out ofHtmlCompilation:isInertRuntimeMediaPlaceholder: runtime media placeholders that never paint.isInertHiddenSvgStorageandhiddenSvgStoreHasNonSvgConsumer: hidden SVG sprite stores that only other SVG content consumes.SourceDom::attrreplaces the trait forward, and collaborators are injected. The three existing closures (PhrasingSvgConverter, the hidden-SVG predicate andVisualIframeBlockGenerator) now call the new owner.HtmlCompilation: 7130 → 7037 lines.Verification
composer validate --strict && lint && test:lint && test):GATE=0.rj/websitecompile, trunk530cf33fvs this branch419adb95, with HEADs asserted:output_sha25649442575…9377on all 4 outputs, byte-identical.AI disclosure: Claude Opus (Anthropic) via Pi/Roadie moved the code with a mechanical mover script, ran the Lab gate and A/B, and wrote this PR for Chris Huber.