Skip to content

fix: carry a block caption carrier's padding and case onto its submit - #2786

Merged
chubes4 merged 6 commits into
trunkfrom
fix/form-submit-caption-box
Oct 14, 2026
Merged

chubes4 merged 6 commits into
trunkfrom
fix/form-submit-caption-box

Conversation

@chubes4

@chubes4 chubes4 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Part of Automattic/static-site-importer#2071. Stacked on #2785.

Problem

A submit whose caption is painted by a block-level inner carrier (<a class="btn"><span class="inner">Send</span></a>, <button><span>) takes its box from that carrier: the button declares padding:0 and the span carries padding:.625em 1.9375em and text-transform. Providers render the caption directly into one button element, so the source carried only color and font properties and the button lost its padding (27px vs the source's 44px) and case.

Consumers take the submit box from this graph (Automattic/static-site-importer#2085 makes the resolved graph authoritative over the per-control style).

Change

  • A button caption carrier (the sole text carrier of a button, or of the element painting an off-screen submit from fix: describe the element that paints an off-screen native submit #2785) now carries text-transform with its typography.
  • A block-level carrier also carries its padding when the button box is unpadded. Inline carriers and padded buttons keep the button's own box.

Evidence

  • New tests/unit/form-submit-caption-box.php (6 assertions): block/inline carriers, padded button, and a responsive carrier variant. 4 fail on trunk; all pass here.
  • The form/button/label unit tests pass locally.
  • Hosted-builder contact page (offline harness with static-site-importer#2085): the submit overlay now carries padding:0.625em 1.9375em, text-transform:uppercase, text-decoration:none. Before, it carried padding:0 and no case.

AI disclosure: implemented with Claude (Pi backend via Roadie); Claude traced the seeder precedence, wrote the change and tests, and ran the verification.

Base automatically changed from fix/form-hidden-submit-presenter to trunk October 14, 2026 13:57
…ion-box

# Conflicts:
#	php-transformer/composer.json
@chubes4
chubes4 merged commit 049dd51 into trunk Oct 14, 2026
11 checks passed
@chubes4
chubes4 deleted the fix/form-submit-caption-box branch October 14, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant