Repository navigation
fix: carry a block caption carrier's padding and case onto its submit - #2786
Merged
Merged
Conversation
…ion-box # Conflicts: # php-transformer/composer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Automattic/static-site-importer#2071. Stacked on #2785.
Problem
A submit whose caption is painted by a block-level inner carrier (
<a class="btn"><span class="inner">Send</span></a>,<button><span>) takes its box from that carrier: the button declarespadding:0and the span carriespadding:.625em 1.9375emandtext-transform. Providers render the caption directly into one button element, so the source carried only color and font properties and the button lost its padding (27px vs the source's 44px) and case.Consumers take the submit box from this graph (Automattic/static-site-importer#2085 makes the resolved graph authoritative over the per-control style).
Change
text-transformwith its typography.Evidence
tests/unit/form-submit-caption-box.php(6 assertions): block/inline carriers, padded button, and a responsive carrier variant. 4 fail on trunk; all pass here.padding:0.625em 1.9375em,text-transform:uppercase,text-decoration:none. Before, it carriedpadding:0and no case.AI disclosure: implemented with Claude (Pi backend via Roadie); Claude traced the seeder precedence, wrote the change and tests, and ran the verification.