Repository navigation
Carry a label text carrier's case onto the label caption - #3036
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
A form label often paints its text through an inner carrier:
<label class="field"><span class="field__label">Name</span><input></label>. The presentation graph resolves the label caption's typography from that carrier (#2209), but the label carrier listTYPOGRAPHY_PROPERTIESleft outtext-transform. Only the button-caption list (CAPTION_PROPERTIES, #2786) carried case. A provider label that renders the caption directly therefore losttext-transform: uppercase. The same list drives inherited text for in-form copy, so copy that inherits its case from an ancestor lost it too.text-transformis an inherited text property like the others, so it belongs in the one list. With it added,CAPTION_PROPERTIESis identical toTYPOGRAPHY_PROPERTIESand is removed.Before / after
Fixture 75 (
/contact, Jetpack-mapped contact form, 1440px), label caption:The presentation graph for that label now reports
"text_transform":"uppercase". Field geometry is unchanged and still matches the source.Coverage
tests/unit/form-label-carrier-case.php(new, 4 assertions; all 4 fail on trunk):Test plan
php tests/unit/form-label-carrier-case.phpcomposer testsuite (612 commands)composer topology-diff -- --baseline tools/topology-diff/baseline.json: topology matches the baselineClaude (Anthropic) via the Pi coding agent wrote the change and tests, and measured the before/after in a real browser. Finalized outside Homeboy (direct worktree run). Chris Huber directed the work.