Repository navigation
fix: describe the element that paints an off-screen native submit - #2785
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Automattic/static-site-importer#2071.
Problem
Hosted builders often keep a native submit for semantics but move it off-screen with inline styles (
position:absolute; left:-9999px; width:1px; height:1px) and paint a captioned sibling in its place (an<a class="…button">Send</a>with nohref). The form layout and presentation graphs described the native control, so providers reproduced a 1px off-screen input and the visible submit disappeared after materialization.Change
FormControlClassifier::presentingElement()resolves the element that paints a native submit: aninput/buttonsubmit moved off-screen by its inline style whose single adjacent non-control, non-navigating sibling carries the same caption. Ambiguous or captionless matches keep the native control.presentedControlElements()maps the shared control enumeration through it index for index, socontrol-Nids stay aligned with the control manifest.FormLayoutGraphBuilderandFormPresentationGraphBuilderdescribe presented elements. Control semantics (topology, classification, provider mapping) still readcontrolElements().<button>does.CssValueInspector::isMovedOffscreenBox()uses the same 999px off-screen thresholdhidesText()applies totext-indent.Evidence
tests/unit/form-offscreen-submit-presenter.php(16 assertions) fails on trunk and passes here. It covers visible, clip-only, mismatched caption, ambiguous, navigating link, and non-submit negatives.#f5a623,#fff, Montserrat 700) at 390/768/1440; on trunk it rendered no visible submit. Quality pass, 0 fallbacks.AI disclosure: implemented with Claude (Pi backend via Roadie); Claude diagnosed the producer entity, wrote the change and test, and ran the Lab verification.