Skip to content

test(control-plane): drain accepted MCP work between tests - #1140

Merged
santoshkumarradha merged 1 commit into
Agent-Field:mainfrom
remote-controlled-man:codex/prflow-9189c4df975c
Oct 30, 2026
Merged

santoshkumarradha merged 1 commit into
Agent-Field:mainfrom
remote-controlled-man:codex/prflow-9189c4df975c

Conversation

@remote-controlled-man

Copy link
Copy Markdown
Contributor

The successful execute_reasoner test can finish while its accepted worker job is still running. A later test replaces the process-wide concurrency limiter, allowing that old job's completion to release a slot in the replacement limiter and make the rejection assertion depend on test order.

Register the existing worker-pool reset as test cleanup after creating the router fixture. Accepted work finishes before temporary payload files are removed and before later tests replace shared state. Existing concurrency-rejection assertions are preserved.

Split from #1137 at the maintainer's request; this PR contains only the two-line MCP test cleanup.

Validation on main c338f01:

  • The three-test initialization/execute/rejection trigger passed.
  • go test -mod=readonly ./internal/handlers -count=1 passed (62.002s) in the existing non-root Linux Go 1.25.14 environment.
  • Changed-file gofmt and git diff --check passed.

The unrelated root formatting overlap is being split separately. The repository-wide formatter and unrelated Python/TypeScript/UI suites were not rerun for this test-only split.

Copilot AI balanced review requested due to automatic review settings October 29, 2026 13:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage gate

Thresholds from .coverage-gate.toml: per-surface ≥ 84%, aggregate ≥ 85%, max per-surface regression ≤ 1.0 pp, max aggregate regression ≤ 0.50 pp.

Surface Current Baseline Δ
control-plane 88.20% 87.40% ↑ +0.80 pp 🟡
sdk-go 93.70% 92.00% ↑ +1.70 pp 🟢
sdk-python 94.72% 93.73% ↑ +0.99 pp 🟢
sdk-typescript 92.50% 90.42% ↑ +2.08 pp 🟢
web-ui 84.89% 84.79% ↑ +0.10 pp 🟡
aggregate 86.11% 85.75% ↑ +0.36 pp 🟡

✅ Gate passed

No surface regressed past the allowed threshold and the aggregate stayed above the floor.

@github-actions

Copy link
Copy Markdown
Contributor

📐 Patch coverage gate

Threshold: 80% on lines this PR touches vs origin/main (from .coverage-gate.toml:thresholds.min_patch).

Surface Touched lines Patch coverage Status
control-plane 0 — ➖ no changes
sdk-go 0 — ➖ no changes
sdk-python 0 — ➖ no changes
sdk-typescript 0 — ➖ no changes
web-ui 0 — ➖ no changes

✅ Patch gate passed

Every surface whose lines were touched by this PR has patch coverage at or above the threshold.

@santoshkumarradha santoshkumarradha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out. The cleanup is scoped to the shared worker state, and the focused handler suite passed locally.

@santoshkumarradha
santoshkumarradha added this pull request to the merge queue Oct 30, 2026
Merged via the queue into Agent-Field:main with commit 9960fbd Oct 30, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants