Repository navigation
test(control-plane): drain accepted MCP work between tests - #1140
santoshkumarradha merged 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
santoshkumarradha
left a comment
There was a problem hiding this comment.
Thanks for splitting this out. The cleanup is scoped to the shared worker state, and the focused handler suite passed locally.
The successful
execute_reasonertest can finish while its accepted worker job is still running. A later test replaces the process-wide concurrency limiter, allowing that old job's completion to release a slot in the replacement limiter and make the rejection assertion depend on test order.Register the existing worker-pool reset as test cleanup after creating the router fixture. Accepted work finishes before temporary payload files are removed and before later tests replace shared state. Existing concurrency-rejection assertions are preserved.
Split from #1137 at the maintainer's request; this PR contains only the two-line MCP test cleanup.
Validation on main
c338f01:go test -mod=readonly ./internal/handlers -count=1passed (62.002s) in the existing non-root Linux Go 1.25.14 environment.git diff --checkpassed.The unrelated root formatting overlap is being split separately. The repository-wide formatter and unrelated Python/TypeScript/UI suites were not rerun for this test-only split.