Skip to content

fix(build): format Go packages without recursive overlap - #1141

Merged
santoshkumarradha merged 1 commit into
Agent-Field:mainfrom
remote-controlled-man:codex/prflow-f5b8723be377
Oct 30, 2026
Merged

santoshkumarradha merged 1 commit into
Agent-Field:mainfrom
remote-controlled-man:codex/prflow-f5b8723be377

Conversation

@remote-controlled-man

Copy link
Copy Markdown
Contributor

The root format target passes every Go package directory to a formatter that recursively walks directories. Parent and child packages therefore schedule the same files more than once, which can fail with “size changed during reading” while formatting writes are in progress.

Use the native go fmt ./... command in both Go modules. It enumerates package files once and retains test and platform-specific files.

Split from #1137 at the maintainer's request. This PR changes only the two Makefile commands; the independent MCP fixture cleanup is in #1140.

Validation on main c338f01:

  • make fmt tidy passed using the existing Linux Go 1.25.14 and native Ruff environment.
  • Native dry runs covered 905 control-plane and 209 Go SDK files, each once.
  • The Makefile remained unchanged by the command. Its 192 unrelated pre-existing formatting changes were restored.
  • git diff --check passed.

The repository-wide test script and unrelated SDK suites were not rerun for this format-command split. The separate MCP test-isolation change is not included in this branch.

Copilot AI balanced review requested due to automatic review settings October 29, 2026 14:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@santoshkumarradha santoshkumarradha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this into a focused fix. The native package formatter avoids the recursive overlap, and the change is nicely contained.

@santoshkumarradha
santoshkumarradha added this pull request to the merge queue Oct 30, 2026
Merged via the queue into Agent-Field:main with commit 5fd106c Oct 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants