Repository navigation
fix(build): format Go packages without recursive overlap - #1141
Merged
santoshkumarradha merged 1 commit intoOct 30, 2026
Merged
santoshkumarradha merged 1 commit into
santoshkumarradha merged 1 commit into
Conversation
remote-controlled-man
requested review from
a team and
AbirAbbas
as code owners
October 29, 2026 14:06
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
santoshkumarradha
approved these changes
Oct 30, 2026
santoshkumarradha
left a comment
Member
There was a problem hiding this comment.
Thanks for splitting this into a focused fix. The native package formatter avoids the recursive overlap, and the change is nicely contained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root format target passes every Go package directory to a formatter that recursively walks directories. Parent and child packages therefore schedule the same files more than once, which can fail with “size changed during reading” while formatting writes are in progress.
Use the native
go fmt ./...command in both Go modules. It enumerates package files once and retains test and platform-specific files.Split from #1137 at the maintainer's request. This PR changes only the two Makefile commands; the independent MCP fixture cleanup is in #1140.
Validation on main
c338f01:make fmt tidypassed using the existing Linux Go 1.25.14 and native Ruff environment.git diff --checkpassed.The repository-wide test script and unrelated SDK suites were not rerun for this format-command split. The separate MCP test-isolation change is not included in this branch.