Skip to content

Cancel superseded PR runs and drop macOS from the integration matrices #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ANcpLua merged 1 commit into from
Oct 14, 2026
Merged

Cancel superseded PR runs and drop macOS from the integration matrices #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agents/skills/dotcov-ci-workflows/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ description: >-
the distinction between PR/main validation and release-triggered packing
and publication. DotCov's Linux/Windows test matrix applies to ordinary CI;
Fallout upstream's release-only cross-platform policy does not apply here.
The `badge-action` Linux/Windows/macOS matrix invokes the composite action with
The `badge-action` Linux/Windows matrix invokes the composite action with
its default tool installation against a local bare origin; preserve that isolation
and its publication dependency so validation never recreates GitHub's `badges` branch.
The `readme-badge-coverage` matrix additionally compares pinned README badge evidence
with fresh measurements of the exact upstream commits. Preserve its evidence files,
local badge origins, and release dependency.
The `consumer-coverage` matrix runs pinned TypeScript/Python upstream suites
on all three hosts, compares native JSON and DotCov counts, and publishes only
on Linux and Windows, compares native JSON and DotCov counts, and publishes only
to a local origin. Keep the report comparisons and release dependency intact.
3. Preserve the observable contracts:
- Publication depends on build, tests, and both package groups. Keep the
Expand Down
8 changes: 4 additions & 4 deletions .github/tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

`consumer_coverage.py` is an integration test used by the `consumer-coverage` job in
[CI](../workflows/nuget-publish.yml). It invokes the current DotCov CLI and the actual
composite badge action. Every PR runs both languages on Linux, Windows, and macOS.
composite badge action. Every PR runs both languages on Linux and Windows.

The upstream projects already have coverage configuration. Their sources and tests are
unchanged: the TypeScript project declares a 100% Jest threshold, and the Python project
Expand Down Expand Up @@ -129,7 +129,7 @@ DotCov's own 100% line/branch gate and the other targets' gates are unchanged.
Pydash uses Python 3.12 and the coverage.py 7.16.0 / pytest 9.1.1 / pytest-cov 7.1.0
versions recorded in its published [Python 3.12 CI job](https://github.com/dgilland/pydash/actions/runs/33272967265/job/99154667022).
That upstream job ran Python 3.12.14. CI selects the available Python 3.12 patch release on
each host (setup-python does not distribute 3.12.14 on Windows or macOS); exact count
each host (setup-python does not distribute 3.12.14 on Windows); exact count
comparisons remain mandatory. Its 2,274 unit tests and doctests run with upstream's targets, source configuration,
exclusions, and 100% gate. CI installs the package editable so per-file paths refer to the
checkout. A local pytest plugin supplies a virtual clock and timer queue only to
Expand All @@ -140,14 +140,14 @@ The plugin replaces module references for those two tests and restores them afte
test; other tests and the Python standard library keep real time. Timers execute pydash's
actual callbacks in deadline order, including cancellation and max-wait behavior.

CI first runs `test_pydash_clock.py` on all three hosts. It repeats both unchanged upstream
CI first runs `test_pydash_clock.py` on both hosts. It repeats both unchanged upstream
tests with real 30 ms scheduling stalls, verifies clock isolation and JUnit evidence, and
proves that deliberately early or late timers still fail upstream assertions. The
full measurement then requires all 2,274 tests to pass with zero skips or errors, evidence
that exactly the two intended tests used the clock, and the same exact coverage counts.
There are no retries, merged partial measurements, extra exclusions, or relaxed thresholds.

A separate `test_pydash_threads.py` suite runs on Linux, Windows, and macOS using pydash's
A separate `test_pydash_threads.py` suite runs on Linux and Windows using pydash's
real clock, `threading.Timer`, and locks, without loading the virtual-clock plugin. Five
scenarios each run three times: background delivery and last-result reuse; cancellation
after a timer has fired; a caller arriving during a blocked callback; eight concurrent
Expand Down
15 changes: 12 additions & 3 deletions .github/workflows/nuget-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ permissions:
contents: read
id-token: write

# A new push to a PR supersedes its running checks. Pushes to main and tags never cancel:
# every merge is validated and a release run always finishes.
concurrency:
group: ci-${{ github.ref }}

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Give non-PR runs distinct concurrency groups

When a main run is active and another is pending, a third main push—or a workflow_dispatch release from main—uses the same ci-refs/heads/main group and cancels the pending run even though cancel-in-progress is false. GitHub documents that a concurrency group retains only one pending run by default, replacing any earlier pending run, so this can skip the promised per-merge validation or discard a queued manual publication; use a unique group for non-PR runs or enable a queue that preserves them. See GitHub's concurrency documentation.

Useful? React with 👍 / 👎.

cancel-in-progress: ${{ github.event_name == 'pull_request' }}

env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_NOLOGO: true
Expand Down Expand Up @@ -104,6 +110,9 @@ jobs:
dotnet tool restore
dotnet fallout Coverage --reports TestResults

# The integration matrices run on Linux and Windows. macOS adds no coverage path of its own
# (POSIX paths like Linux); BadgeActionTests run badge.sh under macOS's bash 3.2 locally.
# macOS runners stay for the release-only osx-arm64 Native AOT pack.
# Exercise the composite action and its default installer against this checkout's portable
# package. A release candidate is not on NuGet yet. Native packages are packed separately;
# the local-only feed prevents an already-published version from masking this checkout.
Expand All @@ -112,7 +121,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
defaults:
run:
Expand Down Expand Up @@ -195,7 +204,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-latest]
language: [typescript, python]
include:
- language: typescript
Expand Down Expand Up @@ -296,7 +305,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-latest]
target: [compare-versions, pydash, peek-readable]
include:
- target: compare-versions
Expand Down
9 changes: 5 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ root, warns, and its gates answer `NODATA`. Where the sources are checked out, a
`--probe-sources` to resolve each file against the root that holds it on disk; anywhere else,
`--source-root <root>` names the root.

CI runs the full suites of two pinned upstream projects on Linux, Windows, and macOS:
CI runs the full suites of two pinned upstream projects on Linux and Windows:

| Language | Real project | Coverage producer | Checks |
|---|---|---|---|
Expand All @@ -92,11 +92,11 @@ out the commit recorded by Coveralls and compares fresh coverage with that publi
| TypeScript async | [peek-readable 5.4.2](https://github.com/Borewit/peek-readable/blob/9cef754de7baad45e43195bbb35bd9bbf30abbc9/README.md) | [Coveralls build 71980502](https://coveralls.io/builds/71980502) | 205/209 lines, 54/57 branches; all 29 tests, real timers |
| Python | [pydash 8.1.0](https://github.com/dgilland/pydash/blob/f46de3669742c075e5379c1e193c86c1c2c70dc2/README.rst) | [Coveralls build 81442862](https://coveralls.io/builds/81442862) | 100%; 2,607/2,607 lines in the published Python 3.12 run; 2,274 tests |

These checks also run on Linux, Windows, and macOS and publish a matching DotCov badge to a
These checks also run on Linux and Windows and publish a matching DotCov badge to a
local test origin. The saved service records bind the reference percentages to the source
commits, so later changes to a moving upstream badge cannot change the expected result.
Pydash collects line coverage only; the existing consumer matrix separately verifies Python
branch coverage and failing gates. Pydash also runs separate real-thread tests on all three
branch coverage and failing gates. Pydash also runs separate real-thread tests on both
hosts for timer cancellation, callback locking, concurrent callers, and maximum wait.


Expand Down Expand Up @@ -194,7 +194,8 @@ falls short of its threshold. A branch rate below its minimum turns the badge re
This repository enforces 100% line and branch coverage in CI without publishing a badge branch.
The badge action below is optional for consumers who want to publish coverage in their own repository.
It runs on Linux, Windows (Git Bash), and macOS runners with .NET installed; CI exercises
installation, publishing, and a failing gate on all three. It creates a `badges` branch on first use:
installation, publishing, and a failing gate on Linux and Windows, and the test suite runs
`badge.sh` under macOS's bash 3.2. It creates a `badges` branch on first use:

```yaml
permissions:
Expand Down
4 changes: 2 additions & 2 deletions tests/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ den Repository-Wrapper ebenfalls als echten Prozess: Parameter, Eingaben und Exi
- Temp-Verzeichnisse über `TempWorkspace`, Kindprozesse über `ChildProcess`.
- `BadgeActionTests` laufen auch unter Windows und wählen dort explizit Git for Windows' Bash
statt eines möglichen WSL-Bash auf PATH. Die `badge-action`-CI-Matrix prüft zusätzlich die
Composite Action mit dem lokal gepackten Kandidaten und ihrem Standard-Installer auf Linux,
Windows und macOS; Pushes gehen ausschließlich an ein lokales Bare-Repository.
Composite Action mit dem lokal gepackten Kandidaten und ihrem Standard-Installer auf Linux
und Windows; Pushes gehen ausschließlich an ein lokales Bare-Repository.

## Isolation messen

Expand Down
Loading