Skip to content

Cancel superseded PR runs and drop macOS from the integration matrices - #80

Merged
ANcpLua merged 1 commit into
mainfrom
ci/linux-windows-only
Oct 14, 2026
Merged

ANcpLua merged 1 commit into
mainfrom
ci/linux-windows-only

Conversation

@ANcpLua

@ANcpLua ANcpLua commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Each push to a PR started a full 26-job run and never cancelled the previous one; PR #79 accumulated over 37 overlapping runs.

  • concurrency cancels a PR's running checks when a newer push arrives. Pushes to main and tags never cancel, so every merge and every release run finishes.
  • badge-action, consumer-coverage and readme-badge-coverage run on Linux and Windows (18 → 12 jobs). macOS adds no path handling beyond Linux's, and BadgeActionTests run badge.sh under macOS's bash 3.2 locally. pack-tool-native keeps its macOS runner for the release-only osx-arm64 Native AOT pack.
  • README, .github/tests/README.md, tests/AGENTS.md and the CI skill now say Linux and Windows.

Required checks (build, test (ubuntu-latest), test (windows-latest)) are unchanged. actionlint passes.

🤖 Generated with Claude Code

A push to a PR now cancels that PR's running checks; pushes to main and tags still always
finish. badge-action, consumer-coverage and readme-badge-coverage run on Linux and Windows
only: macOS adds no path handling of its own, and BadgeActionTests run badge.sh under
macOS's bash 3.2 in local runs. macOS runners remain for the release-only osx-arm64 pack.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 14, 2026 13:00
@ANcpLua
ANcpLua enabled auto-merge (squash) October 14, 2026 13:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T13:04:18.844143Z f5d62b6 PR opened
🔒 Security Review ✅ Completed 2026-10-14T13:04:56.343440Z f5d62b6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ANcpLua
ANcpLua merged commit 7752689 into main Oct 14, 2026
22 checks passed
@ANcpLua
ANcpLua deleted the ci/linux-windows-only branch October 14, 2026 13:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5d62b6102

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# A new push to a PR supersedes its running checks. Pushes to main and tags never cancel:
# every merge is validated and a release run always finishes.
concurrency:
group: ci-${{ github.ref }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Give non-PR runs distinct concurrency groups

When a main run is active and another is pending, a third main push—or a workflow_dispatch release from main—uses the same ci-refs/heads/main group and cancels the pending run even though cancel-in-progress is false. GitHub documents that a concurrency group retains only one pending run by default, replacing any earlier pending run, so this can skip the promised per-merge validation or discard a queued manual publication; use a unique group for non-PR runs or enable a queue that preserves them. See GitHub's concurrency documentation.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants