Skip to content

Drop Python < 3.11, add dependency lower bounds and a min tox env - #24

Merged
wRAR merged 3 commits into
zytedata:masterfrom
kishan3:dependency-lower-bounds
Oct 23, 2026
Merged

wRAR merged 3 commits into
zytedata:masterfrom
kishan3:dependency-lower-bounds

Conversation

@kishan3

@kishan3 kishan3 commented Oct 23, 2026 •

Copy link
Copy Markdown
Member
  • Drops Python 3.9 and 3.10 (requires-python = ">=3.11") and adds Python 3.15.
  • Adds lower bounds in pyproject.toml: lxml>=4.9.1 and lxml-html-clean>=0.1.0.
  • Adds a min tox env that installs exactly those minimums on Python 3.11 (the lowest supported), plus a matching CI job. lxml 4.9.1 is the first release with Python 3.11 wheels, and the full suite passes with it and lxml-html-clean 0.1.0.
  • Updates CI tools: pinned GitHub Actions (same as clear-html), ruff, mypy, pytest, parsel, types-lxml, twine and build. The twine and build bump fixes the twinecheck failure (twine 6.2.0 rejects the metadata version 2.5 that current hatchling emits).
  • Adds strict=True to a zip() in the tests, which the newer ruff flags now that Python 3.10+ is the floor.

lxml.html.clean only moved to the separate lxml-html-clean package in lxml 5.2; older lxml versions still ship it themselves, so the minimum pair works either way.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.28%. Comparing base (2dc4e94) to head (2759922).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files           2        2           
  Lines         105      105           
  Branches       19       19           
=======================================
  Hits           99       99           
  Misses          4        4           
  Partials        2        2           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/test.yml Outdated
TOXENV: py39-parsel
- python-version: "3.9"
env:
TOXENV: pinned

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s call it min, I think that’s what we are calling it in most repos.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, renamed to min.

@AdrianAtZyte

Copy link
Copy Markdown

If you feel like it, this may be a nice opportunity to drop Python < 3.11, and support up to 3.15. And upgrading the CI tools as well, which should address the twinecheck issue.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kishan3

kishan3 commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

If you feel like it, this may be a nice opportunity to drop Python < 3.11, and support up to 3.15. And upgrading the CI tools as well, which should address the twinecheck issue.

Sure @AdrianAtZyte , Should I do it in same PR?

@AdrianAtZyte

Copy link
Copy Markdown

Should I do it in same PR?

Yes, I think that would be simpler.

The lowest supported Python is now 3.11, so the min env uses lxml 4.9.1,
the first release with Python 3.11 wheels.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kishan3 kishan3 changed the title Add dependency lower bounds and a minimum-versions tox env Drop Python < 3.11, add dependency lower bounds and a min tox env Oct 23, 2026
@kishan3

kishan3 commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

Done in the same PR as suggested: Python < 3.11 dropped, 3.15 added, CI tools updated (this also fixes twinecheck). All checks pass.

@AdrianAtZyte
AdrianAtZyte requested a review from wRAR October 23, 2026 12:11
@wRAR
wRAR merged commit 3955be2 into zytedata:master Oct 23, 2026
10 checks passed
@kishan3
kishan3 deleted the dependency-lower-bounds branch October 23, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants