Skip to content

fix URI encoding - #414

Merged
zFernand0 merged 1 commit into
mainfrom
fix-uri-encoding
Sep 2, 2026
Merged

fix URI encoding#414
zFernand0 merged 1 commit into
mainfrom
fix-uri-encoding

Conversation

@jace-roell

@jace-roell jace-roell commented Sep 1, 2026

Copy link
Copy Markdown
Member

What It Does
Fixes URI encoding
Normalizes URIs and ensures safe encoding

How to Test
Run test_sdk_api.py

Review Checklist
I certify that I have:

  • updated the changelog
  • manually tested my changes
  • added/updated automated unit/integration tests
  • created/ran system tests (provide build number if applicable)
  • followed the contribution guidelines

Additional Comments

Signed-off-by: jace-roell <jace.roell@hotmail.com>
@github-project-automation github-project-automation Bot moved this to New Issues in Zowe CLI Squad Sep 1, 2026
@zowe-robot zowe-robot moved this from New Issues to In Progress in Zowe CLI Squad Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.50%. Comparing base (7346994) to head (0ee86e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   85.49%   85.50%           
=======================================
  Files          49       49           
  Lines        2993     2995    +2     
=======================================
+ Hits         2559     2561    +2     
  Misses        434      434           
Flag Coverage Δ
unittests 85.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jace-roell
jace-roell marked this pull request as ready for review September 2, 2026 13:25
@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe CLI Squad Sep 2, 2026
@jace-roell
jace-roell marked this pull request as draft September 2, 2026 15:06
@zowe-robot zowe-robot moved this from Review/QA to In Progress in Zowe CLI Squad Sep 2, 2026
@jace-roell jace-roell changed the title init fix URI encoding Sep 2, 2026
@jace-roell
jace-roell marked this pull request as ready for review September 2, 2026 18:19
@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe CLI Squad Sep 2, 2026

@t1m0thyj t1m0thyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jace-roell!

@zFernand0 zFernand0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

I don't think we have seen a z/OSMf endpoint that requires a trailing / yet, so this should be fine.

Quick test script: (click here) ⬇️

Source: test script via https://playcode.io/python-playground
Image

import posixpath

# Sample paths to test
test_paths = [
    "foo//bar/",
    "foo/./bar",
    "foo/../bar",
    "../foo/bar",
    "/../foo/bar",
    "foo/bar/../../baz",
    "///foo/bar",
    "",
]

print(f"{'Original Path':<25} | {'Normalized Path':<20}")
print("-" * 50)

for path in test_paths:
    # os.path.normpath uses posixpath mechanics on POSIX systems (Linux/Mac)
    # Using os.path.posixpath directly ensures POSIX behavior on any OS
    normalized = posixpath.normpath(path)
    print(f"{repr(path):<25} | {repr(normalized):<20}")

@zFernand0
zFernand0 merged commit 5f8f8bc into main Sep 2, 2026
24 of 25 checks passed
@zFernand0
zFernand0 deleted the fix-uri-encoding branch September 2, 2026 20:49
@github-project-automation github-project-automation Bot moved this from Review/QA to Closed in Zowe CLI Squad Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

4 participants