Repository navigation
flatten analysis test build steps into build.zig - #3287
Merged
Merged
Conversation
92d5bbf removed tests/ from build.zig.zon, but add_analysis_cases.zig is imported with @import() in build.zig, causing configure error: ``` error: adding build_root zig-pkg/zls-0.17.0-dev-rmm5fgEnHAB2MTEid91hbT8mVqvuEYQvtOXQDfX7lqN2/tests/add_analysis_cases.zig to cache failed: FileSystemFailure ``` Flatten the file into build.zig directly, since all the paths used in that file are all relative to build.zig anyway and I see little benefit in extracting it in its own file. Fixes: 92d5bbf (exclude unnecessary build steps and files when being a dependency)
iceghost
force-pushed
the
push-rkwnovsllrpo
branch
from
October 17, 2026 07:11
4364630 to
c145c56
Compare
iceghost
changed the title
techatrix
approved these changes
Oct 17, 2026
techatrix
left a comment
techatrix
left a comment
Member
There was a problem hiding this comment.
I moved the function above the definition of Build but otherwise looks good to me. Thanks and sorry for the breakage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
92d5bbf removed tests/ from build.zig.zon, but add_analysis_cases.zig is imported with @import() in build.zig, causing configure error:
Flatten the file into build.zig directly, since all the paths used in that file are all relative to build.zig anyway and I see little benefit in extracting it in its own file.
Fixes: 92d5bbf (exclude unnecessary build steps and files when being a dependency)