Bad completion and signature help on functions assigned to const #3282

Activity

1. psznm

   added

   bugSomething isn't workingSomething isn't working

   on Oct 16, 2026
2. psznm commented on Oct 17, 2026

   

   psznm

   on Oct 17, 2026

   Last edited by psznm

   ContributorAuthor

   More actions

   I made little progress on this. I managed to fix a test regarding this that I added. I thought the issue was that a hasSelfParam function returned false for the function in question. But fixing that broke one of the assertions (the last one) in completion "function alias" test which apparently relied on the broken hasSelfParam, and one more test that seemed to have suffered from the same issue. Not fully understanding what is going on, not sure if hasSelfParam is wrong or is just being given wrong data, I took a step back and started debugging to understand more. Eventually as I learned debugging what exactly is being inspected (some dedicated debug utils would be really nice), I found that hasSelfParam = false was reported for fn foo in

   const S = struct {
       fn foo(_: S, _: enum{ alpha, beta }) void {} // reported has self param = false during getting completions for s.bar
       const bar = foo;
   };
   const s: S = undefined;
   const baz = s.bar(.<cursor>); // missing completons, if I add fields on S, it tries to complete fields of S
   

   And since there was a condition for namespace I made sure that it is being badly reported also for non-namespaces - for non namespaces it just tries to complete fields of the container.

   So I came to the conclusion that the hasSelfParam is indeed wrong and needs to be fixed. So my fix of hasSelfParam, while maybe correct, broke other things that rely on hasSelfParam being wrong. So I will see if I can fix that too...
3. techatrix commented on Oct 17, 2026

   

   techatrix

   on Oct 17, 2026

   Member

   More actions

   Yes hasSelfParam is indeed flawed for the following reasons:

   • Namespaces (struct with no fields) can actually be called with the my_namespace.my_func() syntax. Related Methods on namespaces #3278
   • It compares the first parameter with the container type the function is defined in as opposed to using the type of foo in foo.my_func() which doesn't have to be same because my_func might be an alias.

   I addressed this for signature help by replacing hasSelfParam with firstParamIs in #3290. The same should be done for autocomplete which I haven't look much into yet. Let me know if I can do anything to assist.