Repository navigation
test(web): witness the composer's bottom space and its clear top edge - #165
Merged
Merged
Conversation
Two owner reports from 2026-10-09 get geometry witnesses in the owner-reported layout regressions suite, at 1786 x 1000 with the 435 px menu: - "the conversation runs to the window's bottom and a recovery result arriving moves neither the composer nor the conversation" (fixed by #152: recovery results became toasts instead of a strip under the main column). With nothing to report the docked footer ends at the window's bottom and the card sits one gutter above it; an "accepted" then a "Start failed." result leave the card and the conversation boxes unchanged. - "the conversation shows right up to the composer card's top edge" (fixed by #154/#161: the dock is opaque only from the card's top edge down). Paint, not elementFromPoint: the footer is pointer-events-none, so hit-testing skips the old opaque band too. The two pixel rows above the card change when the conversation is hidden, stepping 5 px at a time until text passes. Nothing painting below the card stays with "history does not paint through the composer footer". Failed before: with the old always-present "Recovery results" strip restored, the footer ended at 960 instead of 1000, and with the quiet checks skipped a result arriving moved the card 4 px (top 733 -> 729). With the old `bg-background pt-1.5 sm:pt-2` footer, the strip above the card never changed over 12 steps. On main both pass, 3 of 3 runs of the suite file (13 tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two geometry witnesses in the
owner-reported layout regressionssuite for the owner's 2026-10-09 composer reports (1786 x 1000, 435 px menu):pointer-events-none, soelementFromPointwould skip the old opaque band too. The area below the card stays covered by "history does not paint through the composer footer".Failed before: restoring the old strip, the footer ended at 960 instead of 1000, and a result arriving moved the card 4 px. Restoring the old
bg-backgroundfooter, the strip above the card never changed. On main the suite file passes 3 of 3 runs, andgate-changedis green.🤖 Generated with Claude Code