Repository navigation
core: arduino: add common files for compatibility - #205
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds placeholder Arduino core header files to improve compatibility with third-party libraries that unconditionally include them, addressing the missing-header build failures referenced in #393.
Changes:
- Added
cores/arduino/wiring_private.has an (intended) empty compatibility header. - Added
cores/arduino/pins_arduino.has an (intended) empty compatibility header.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cores/arduino/wiring_private.h | Adds a compatibility stub header for libraries expecting wiring_private.h. |
| cores/arduino/pins_arduino.h | Adds a compatibility stub header for libraries expecting pins_arduino.h. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
add empty files: pins_arduino.h resolves: #393 Also mentioned in a pull request against one of the Adafruit libraries: adafruit/Adafruit_ILI9341#103 Which has not been touched for several months. Co-authored-by: Kurt Eckhardt <kurte@rockisland.com> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
DhruvaG2000
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add empty files:
pins_arduino.h
resolves: #393
Also mentioned in a pull request against one of the Adafruit libraries: adafruit/Adafruit_ILI9341#103 Which has not been touched for several months.