Repository navigation
core: Fixes for proper core compatibility - #203
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves Arduino core compatibility for the Zephyr-based core by ensuring common math functions are available when consumers include Arduino.h, aligning with typical Arduino-core expectations.
Changes:
- Add a direct
#include <math.h>to the core’s primary public header to make math APIs available transitively.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adding include math.h for improve core compatibility. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
soburi
force-pushed
the
improve_core_compat
branch
from
July 5, 2026 14:31
399fd9f to
53b0ecb
Compare
DhruvaG2000
approved these changes
Aug 20, 2026
DhruvaG2000
left a comment
DhruvaG2000
left a comment
Member
There was a problem hiding this comment.
Just fix the commit title its a trivial change and it should describe just that.
The description can have the part where its fixing and what it is fixing.
I hope you will address that and then merge, thnx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding include math.h for improve core compatibility.