Repository navigation
feat(browser): route managed Chrome through the policy proxy - #6
Open
aaqaishtyaq wants to merge 1 commit into
Open
aaqaishtyaq wants to merge 1 commit into
aaqaishtyaq wants to merge 1 commit into
Conversation
Share proxy arguments between desktop and headless browser launchers. Pass ZEISH_EGRESS_PROXY to Chrome, keep private guest routes direct, and disable QUIC to route public requests through the policy proxy. Ignore tenant NO_PROXY values when constructing the browser bypass list. Fail startup when a managed browser cannot load the shared helper. Document base-before-desktop release order and browser restart behavior. Add a PR test gate covering both launchers and the missing-helper case. Verified six focused tests on the host and in a Linux container, bash syntax for all modified scripts, and both Dockerfile build checks. A real Chromium CDP smoke test in a network-isolated container confirmed public HTTP and HTTPS proxy routing despite NO_PROXY=*, plus direct loopback and .internal requests to private fixture services. Signed-off-by: Aaqa Ishtyaq <aaqaishtyaq@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome ignores conventional HTTP proxy environment variables, so desktop and headless browsers could fail to reach public sites when Compute enabled a policy proxy. Both Zeish launchers now pass
ZEISH_EGRESS_PROXYthrough a shared Chrome flag helper.The helper disables QUIC, bypasses the proxy only for loopback and
.internalguest routes, and does not copy tenantNO_PROXYentries. Managed launchers fail before startup if the shared helper is missing. Host network policy remains responsible for rejecting protected destinations and direct bypass traffic.Release the updated
baseimage beforedesktop-x11, which inherits the helper. Restart an existing browser if its proxy environment changes; policy updates at the same proxy endpoint affect new requests. The documentation records this release order and contract.Companions: zeishdev/compute#145 and zeishdev/cloud#128.
Validation:
NO_PROXY, both launch paths, and failure when the helper is absent.bash -npassed for both launchers and the shared helper.docker build --check images/baseanddocker build --check images/desktop-x11passed without warnings.NO_PROXY=*, plus direct requests to.internaland loopback fixture services.Full release image builds, X11 browser qualification, and the live Compute egress matrix remain rollout gates. The Chromium smoke used the existing local browser image with the changed launcher and helper mounted into it.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.