Repository navigation
cache metrics: route results & first-hit - #4385
Closed
larry-dalmeida wants to merge 2 commits into
Closed
larry-dalmeida wants to merge 2 commits into
larry-dalmeida wants to merge 2 commits into
Conversation
This was referenced Oct 26, 2026
larry-dalmeida
force-pushed
the
metrics-b-family-result
branch
from
October 26, 2026 13:25
21cb767 to
b5b93ac
Compare
Add skipper_cache_lru_entries{route} and skipper_cache_lru_capacity_bytes gauges. ShardedByteLRU.Usage returns bytes and entry count together; Bytes delegates to it.
Signed-off-by: Larry D Almeida <hello@larrydalmeida.com>
larry-dalmeida
force-pushed
the
metrics-b-family-result
branch
from
October 26, 2026 14:36
b5b93ac to
1155173
Compare
larry-dalmeida
force-pushed
the
larry-almeida-zse-cache-timeouts-pr
branch
from
October 26, 2026 14:37
509147c to
7e48ec0
Compare
This was referenced Oct 26, 2026
Count hit, stale, and miss outcomes per route ID and record the time from process start to the first cache hit. Signed-off-by: Larry D Almeida <hello@larrydalmeida.com>
larry-dalmeida
force-pushed
the
metrics-b-family-result
branch
from
October 27, 2026 07:50
1155173 to
ccc4f36
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds per-route cache result tracking (hit/miss/stale) and first-hit observation time.
How to Verify
Shared setup
make verifystarts or reuses Minikube, the mock origin and the stack; runs the smoke and coalescing checks; and validates supported dashboard queries. It prints a report path and exits non-zero on failure. For outage evidence, runmake chaos SKIPPER_CHECKOUT=../skipper-pr-4387 NAME=origin-stale; it includes its own timed load. Requirements: Python 3.9+, Make, Bash, Git, curl, kubectl, Minikube, Docker and Go compatible with Skipper'sgo.mod. Free ports: 8080, 8081, 6379, 4318, 9091, 9999, 9911 (8089 for endless load). Dynamic URLs:.runtime/urls.txt; stop withmake stop.Validated on #4387 (
d767f636): smoke: 6,398 requests, 0 failures; origin-stale: 155 failed revalidations across 77 routes. Smoke metric checks: 42 PASS, 2 fault-only NOT EXERCISED, 0 FAIL.Focused tests
Expected: 3 focused tests pass.
skipper_cache_route_result_total{route,result}labels configured route IDs, so cardinality follows route count, not URLs. Dashboard PromQL derives route families only for IDs matching<family>__<variant>; other setups can group by route or adapt the expression. First-hit metric has samples.Checklist
Rollback Plan
Revert this PR to restore previous metrics behavior. Revert #4386 first if merged.
References & Additional Context
Depends on #4384; followed by #4386. Adds per-route result distribution and first-hit timing metrics.
E2E Evidence
Latest-chain verification: smoke report (6,398 requests, 0 failures). The stack run uses #4387, which includes this PR; see the shared setup above.