Repository navigation
feat(compile): unify FSDP planning and TextTrainer backend execution - #20
Open
yu-chen-code wants to merge 3 commits into
Open
yu-chen-code wants to merge 3 commits into
yu-chen-code wants to merge 3 commits into
Conversation
yu-chen-code
force-pushed
the
master-graph-fsdp-unified
branch
from
November 11, 2026 13:11
be3c72d to
6209376
Compare
yu-chen-code
force-pushed
the
master-graph-fsdp-unified
branch
from
November 12, 2026 08:21
6209376 to
36d438f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind refactor
What does this PR do / why do we need it:
Share execution-independent FSDP planning between eager execution and TextTrainer joint graphs, and connect the graph's terminal backend without changing eager scheduling. The changes are split into three commits:
compile.inductor_modeandcompile.inductor_configsindependently of decoder compilation options. Retain the terminal executable and its training metadata, size backend inputs from physical shards, and preserve the positional state/input calling convention.offexecutes FX directly; requesting an unavailable backend fails explicitly. This does not add an NPU Inductor scheduler.The three feature PRs are stacked on separate new branches. This aggregate PR retains exactly three commits over fork master and can be reviewed as the complete change.
The series uses new branches. Existing PR13 and PR15 branches are unchanged. This PR does not associate or close any issue.
Validation uses Python 3.12.13, PyTorch 2.15.0.dev20261005+cpu and torch-npu 2.15.0. The aggregate head has 205 focused unit tests and 181 subtests passing; the separate Inductor suite has 16 tests passing and two existing strict-equality subtest failures. Both failures reproduce on the exact master baseline with the same values (0.701689600944519 versus 0.7016897201538086); assertions are unchanged.
no scheduling registered for device npu; NPU Inductor execution is not claimed.Which issue(s) this PR fixes:
None
Code review checklist [illustration]: