Repository navigation
feat(compile): bridge graph parameter storage to checkpoint chunks - #14
Open
yu-chen-code wants to merge 3 commits into
Open
yu-chen-code wants to merge 3 commits into
yu-chen-code wants to merge 3 commits into
Conversation
yu-chen-code
force-pushed
the
feat-graph-checkpoint-layout
branch
from
November 9, 2026 11:25
d0cb4ff to
813f984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do / why do we need it:
Refreshed on 2026-11-09 against fork/upstream master
a6be99d3. PR1421 is now merged upstream, so its duplicate prerequisite has been removed. Current head:813f984f07e466a6549193d5c2b85c539bc4a1bd; retained feature/dependency commits:c7d02fea,bf0eb74c,813f984f. Git range-diff confirms unchanged feature patches. Focused CPU regression on this exact head: 141 JUnit records, 0 failures, 0 errors. The isolated refresh environments now include master-required PEFT 0.21.2 and accelerate 1.13.0; pip check passes. All numerical runs and older source hashes below are pre-refresh evidence. NPU precision training and formal upstream CI were not rerun for this rebase.Connect graph-owned FSDP storage to the existing DCP and Hugging Face checkpoint paths using parameter ownership metadata.
Validation on deploy32, four Ascend910B2 cards, Python3.12.13 and Torch/torch-npu2.15:
d0cb4ffab1abdb52a71860f1c76cd0a9900a4326: 57 unit tests and 17 subtests passed, covering original checkpoint/DCP/HF regressions, logical padding, aliases, optimizer/main ownership, container metadata, supplied HF mappings and live lazy-state restoration. Both public-CI Pylint configurations report zero unresolved findings for the new three-file restore increment; the earlier wider scope retains its four documented baseline ExportableModel helper warnings. No suppression, filter or skip was added.f0b60c33704c4507e9d565e444fe69d91c14aadcincludes the independent true-unused capture fix from PR16 and the checkpoint increment. The two checkpoint production files have identical blobs to the current PR head; the complete source trees differ. Combined CPU passes 41 unit tests and 23 subtests, plus explicit FP32/BF16 storage, FP32 main-gradient, None and clipping contracts.e74807c7retain the five-row padding/zero-valid-row rank, tied aliases, scalar, buffer and independently reconstructed export-coordinate coverage (1552 exact tensor comparisons). These remain historical evidence; they are not claimed as a full-tree numerical run of the new PR head. Source/import hashes and pip check were verified before and after each new run.The graph-only cleanup closes a restore-state contract exposed by true-unused gradients; the underlying DCP priming behavior predates this PR. Complete unused graph capture is supplied by independent PR16, not added by this bridge. NPU BF16-storage resume, full HF file load/export, cross-topology or mid-microbatch recovery, PP with unused gradients and full DSV4.1 training remain outside this acceptance.
Reproduction:
T020
runs/20261106-graph-capability-spikes/audit-unused-checkpoint/final-verification.jsonandcheckpoint-blob-equivalence.jsonrecord the exact independent CPU and combined NPU heads, raw commands, tensor receipts and blob correspondence. The earliercheckpoint/final-verification.jsonremains the separate historical all-used geometry record.Which issue(s) this PR fixes:
None.
Code review checklist [illustration]: