Skip to content

refactor(ui): use shared localization keys - #474

Open
camrun91 wants to merge 1 commit into
mainfrom
refactor/use-shared-localization-strings
Open

camrun91 wants to merge 1 commit into
mainfrom
refactor/use-shared-localization-strings

Conversation

@camrun91

@camrun91 camrun91 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Migrate React-specific string references to the shared strings already present in the locale bundles. Equivalent UI labels and actions now use the shared keys directly.

What changed

  • Replace 18 callers across 13 legacy keys and update matching test assertions.
  • Add a repeatable migration checker and a UI patch changeset.
  • Document the 12 shared keys missing in Korean and Czech, including affected components and upstream investigation references.

Scope

  • Equivalent actions, search labels, headings, and passage errors.
  • Keep distinct messages and generated locale files unchanged.

Tradeoffs

The requested direct migration accepts English fallback while Korean and Czech translations are missing. Text changes for 11 keys in Korean and 10 in Czech. Version search already used English in both locales.

Blast Radius

Reader, picker, card, sharing, and permission UI use the existing shared translations. English search labels and some other locale wording change to the canonical shared text.

Verification

  • Forced UI build, full unit suite with 1,090 passed and 2 skipped, typecheck, lint, i18n parity, and migration check passed.
  • Chromium Storybook ran 54 tests across seven files. 53 passed. The unchanged Navigate And Focus viewport assertion also fails with all changed production files restored to main, with identical values.
  • SDK i18n tests cover Korean and Czech shared translations and fallback. A separate resource-resolution check covered all 19 locales. Browser stories ran in English.

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

The PR appears safe to merge with the explicitly accepted Korean/Czech English fallback.

Summary

Replaces 18 production callers across 13 legacy localization keys with existing shared keys. Updates matching tests and adds migration documentation and a repeatable checker.

  • Search and picker labels now come from shared translation keys.
  • Share, cancel, and close controls now use shared translated labels.
  • Reader font choices and the Bible App title use shared translation keys.
  • Error headings and unavailable-passage messages use shared translation keys.
  • A migration checker reports leftover callers and missing Korean and Czech translations.

Reviews (1) · Last reviewed commit: "refactor(ui): use shared localization ke..." · Reviewed by Greptile

@changeset-bot

changeset-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ea09a52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@youversion/platform-react-ui Patch
vite-react Patch
@youversion/platform-core Patch
@youversion/platform-react-hooks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant