Let New project select an execution machine#865
Open
amadad wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The project-create contract and remote folder browser already support a host ID, but the New project UI always targeted the primary host. Multi-machine users therefore had to leave the UI and use
bb project create --machine ....This keeps the host decision in the project path dialog and passes the selected host through the existing create contract. It does not change the server, database, HTTP API, or host-daemon protocol.
Verification
pnpm exec turbo run test --filter=@bb/app— 285 files, 2,083 tests passedpnpm exec turbo run typecheck --filter=@bb/apppnpm exec turbo run lint --filter=@bb/app— 0 errorsgit diff --checkhostId; the offline machine remained disabled