fix(main): read balance instead of nonexistent balance_dollars field - #1
Open
mikepapierz-web wants to merge 1 commit into
Open
fix(main): read balance instead of nonexistent balance_dollars field#1mikepapierz-web wants to merge 1 commit into
mikepapierz-web wants to merge 1 commit into
Conversation
Kalshi's /portfolio/balance response has no balance_dollars key, only balance (integer cents). The stale field check always failed, so the bot silently fell back to the hardcoded BANKROLL default instead of sizing off the live account balance. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.pychecked for abalance_dollarskey in the/portfolio/balanceresponse to size the bot's bankroll off the live account balancebalanceas integer cents (confirmed against a live account, and against this repo's ownbot_state.py, which already readsraw.get("balance")correctly elsewhere)BANKROLLconfig default on every run instead of ever using the real account balance for position sizingFix
'balance' in balance_responseand convert cents to dollars, matching the convention already used inbot_state.pyTest plan
/portfolio/balancereturnsbalance(cents), notbalance_dollarsbot_state.py:43)