Skip to content

chore: update esbuild#152

Merged
asanehisa merged 3 commits into
mainfrom
vuln
Jun 17, 2026
Merged

chore: update esbuild#152
asanehisa merged 3 commits into
mainfrom
vuln

Conversation

@asanehisa

@asanehisa asanehisa commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

https://yext.atlassian.net/browse/VULN-44970?atlOrigin=eyJpIjoiYmVjMDZmNjE0ZjkyNGJhOWIxZjJkZTg3YjAyZjNhOTAiLCJwIjoiaiJ9

After upgrading to esbuild@0.28.1, Storybook was still building against older browser targets, which caused esbuild to fail while transforming destructuring in Storybook/addon dependency code. This updates Storybook’s Vite/esbuild target to es2022 for Storybook builds and tests.

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f3b77bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1f8213a4-4c05-408b-b18b-416041e571b7

📥 Commits

Reviewing files that changed from the base of the PR and between e07f5ae and f3b77bc.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • package.json
  • packages/pages-components/.storybook/main.ts
  • packages/pages-components/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

Walkthrough

The root package.json bumps tsx from ^4.19.3 to ^4.22.4 and adds an esbuild override pinned to 0.28.1 in the pnpm.overrides block. In packages/pages-components/package.json, tsup is bumped from ^8.0.1 to ^8.5.1 and vite-tsconfig-paths from ^4.2.2 to ^6.1.1. The packages/pages-components/.storybook/main.ts gains a viteFinal async hook that deep-merges the existing Vite config and forces both build.target and optimizeDeps.esbuildOptions.target to es2022.

Possibly related PRs

  • yext/js#144: Also updates packages/pages-components devDependency versions related to Storybook and Vite tooling.

Suggested reviewers

  • mkilpatrick
  • jwartofsky-yext
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: update esbuild' is somewhat related to the changeset but lacks sufficient specificity about the primary fix.
Description check ✅ Passed The description clearly explains the issue, the root cause after upgrading esbuild, and the solution applied to fix the compatibility problem.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vuln

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asanehisa asanehisa marked this pull request as ready for review June 16, 2026 21:01
@asanehisa asanehisa merged commit 071eedd into main Jun 17, 2026
26 checks passed
@asanehisa asanehisa deleted the vuln branch June 17, 2026 13:14
asanehisa added a commit to yext/pages that referenced this pull request Jun 17, 2026
https://yext.atlassian.net/browse/VULN-44975?atlOrigin=eyJpIjoiZWU1ODMyZWY4NzM1NGQwOThkMzdlMTdmZjkxNTk0ODYiLCJwIjoiaiJ9

Similar change to yext/js#152

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants