main: get font paths using fontconfig and make Makefile more packager friendly - #1
Open
AnInternetTroll wants to merge 1 commit into
Open
Conversation
… friendly By using fontconfig the program can find a font without hardcoding paths which only work on some distros, but not others. In addition, the Makefile is changed to allow for easier building and changing where the package is installed. Lastly, add a guix.scm file for easier development and as a proof of concept on how to package simplefuckingtimer for distros.
Owner
|
Thank you so much for your effort reviewing this piece of code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using fontconfig the program can find a font without hardcoding paths
which only work on some distros, but not others.
In addition, the Makefile is changed to allow for easier building and
changing where the package is installed.
Lastly, add a guix.scm file for easier development and as a proof of
concept on how to package simplefuckingtimer for distros.
I know this is a lot of changes and not all are necessary, so feel free
to only pick what you think is best.
I tried to keep the build system to one makefile, but of course the C++
world has a lot of opinions on this.
Shoutout to Eli Schwartz in particular for making a version with
autoconf
https://paste.xinu.at/eh8kfH/
I don't really feel comfortable enough with autoconf to use that one,
but feel free to use it.
Lastly, I also got it to build with void's build system with the
following template (also as a proof of concept, but also because void is
what I use)
This doesn't make sense to have in this repo, but it's a good point of
reference for how the program can be packaged in other distros.