Repository navigation
Make docs manual-dispatch deploy branch explicit - #137
Merged
Merged
Conversation
A workflow_dispatch of docs.yml on main is an intentional production
rebuild. Rename the non-release deploy step accordingly and pass
--branch=${{ github.ref_name }} so the Pages branch (production vs
preview) is explicit rather than inferred from git by wrangler.
Skip the PR lookup/comment on main: there the deploy is production and
the associated PR is the already-merged one, which previously got a
misleading "Preview deployed" comment (e.g. #49).
Fixes #113
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
A
workflow_dispatchofdocs.ymlonmainis meant to be a manual production rebuild. The step name said "preview", and the branch came implicitly from git. This makes it explicit:cf_publish_dispatch.--branch=${{ github.ref_name }}. A dispatch onmaindeploys to production and any other branch gets a preview. wrangler-action runscommandvia@actions/execwithout a shell, and ref names can't contain whitespace, so the interpolation stays a single argument.main. They still post preview links when a PR branch is dispatched (e.g. run 24766436972 → Fix docs code block line breaks #52). They no longer post a misleading "Preview deployed" comment on an already-merged PR after a production rebuild. This meanspull-requests: write(see Declare explicit GITHUB_TOKEN permissions in workflows #135) is still needed.Manual check from the issue: confirm in the Cloudflare dashboard that
CLOUDFLARE_API_TOKENonly has Account → Cloudflare Pages → Edit.🤖 Generated with Claude Code