New tests and file README updated#27
Open
Mukhadim08 wants to merge 2 commits into
Open
Conversation
irisqul
reviewed
Apr 21, 2026
There was a problem hiding this comment.
Нужно исправить: из финального проекта нужно удалить все файлы и папки, которые не относятся к решению задачи
| def test_add_new_book_add_two_books(self): | ||
| # создаем экземпляр (объект) класса BooksCollector | ||
| collector = BooksCollector() | ||
| @pytest.fixture |
There was a problem hiding this comment.
Нужно исправить: фикстуры нужно расположить в файле conftest.py
| collector.add_new_book('Оно') | ||
| collector.add_book_in_favorites('Властелин колец') | ||
| collector.add_book_in_favorites('Оно') | ||
| assert collector.get_list_of_favorites_books() == ['Властелин колец', 'Оно'] No newline at end of file |
There was a problem hiding this comment.
Нужно исправить: отсутствуют тесты на проверку метода get_books_genre и позитивный тест на get_book_genre. На каждый метод должен быть отдельный тест, вне зависимости, вызывается он в других тестах или нет
| collector = BooksCollector() | ||
| @pytest.fixture | ||
| def collector(self): | ||
| return BooksCollector() |
There was a problem hiding this comment.
Отлично: в каждом тесте создается собственный экземпляр BooksCollector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.