Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes undefined behavior in
yaml_string_extend,yaml_stack_extend, andyaml_queue_extend.After a successful
realloc, pointers into the original allocation are invalid. The functions previously calculated sizes and offsets using those invalidated pointers after callingyaml_realloc.The change calculates all required sizes and offsets before reallocating, then reconstructs the internal pointers relative to the new allocation.
Reproduction
The issue is detected with Clang’s pointer-pair sanitizer:
-fsanitize=address,pointer-subtractASAN_OPTIONS=detect_invalid_pointer_pairs=2:halt_on_error=1Before the fix, extending a string reports:
The same pattern existed in the stack and queue extension helpers.
Tests
Added
test-realloc, which exercises:Verified with: