Ignore the old revision in anti-affinity so rollouts keep their node - #121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rolling update starts the new pod while the old one still runs, so hostname anti-affinity pushed every single-replica Deployment off its node on each restart. Scheduler logs showed that 200-point penalty decides placement. matchLabelKeys [pod-template-hash] limits each rule to its own revision, and scale-out still spreads.
Argo CD gets matchLabelKeys on its spread constraint, and its anti-affinity preset goes to none because the preset cannot take the field. The redis-operator rule never matched its pod, which carries only a
namelabel.