Report ignored .xlsx sheets for both files in faircode compare - #314
Merged
Conversation
Added tests for comparing multi-sheet and single-sheet XLSX files, ensuring proper handling of ignored sheets.
Contributor
|
@propcgamer20-png is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
ahmdkaml
approved these changes
Aug 25, 2026
Collaborator
|
@yakew7 can't find any blocker I believe it's good for merge |
yakew7
added a commit
that referenced
this pull request
Aug 26, 2026
New version bucket (2.0.12) covers all 12 non-explainer issues closed this session (#247, #251, #284, #302, #271, #303-#306, #301, #286, #309) plus propcgamer20-png's bundled #314 (closing #300, #307, #308, #310), which hadn't been credited in CONTRIBUTORS.md yet - now at 7 merged PRs / 20 commits. Live GitHub numbers (stars/forks/watchers/ contributors) are unchanged since the last snapshot, so no new METRICS.md row - just a note on the existing 2026-W35 entry and an issues-closed count refresh (14 -> 30, past 7 days).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report ignored .xlsx sheets for both files in faircode compare
faircode profile already prints a note when an .xlsx has sheets
besides the one actually read; compare silently profiled sheet 0
of each workbook with no indication others existed - misleading
when a drift report is actually comparing the wrong tabs.
Closes #300
Closes #308
Closes #307
Closes #310