Security: Webhook request body is buffered without size limit (DoS risk)#1300
Open
tuanaiseo wants to merge 1 commit intoyagop:masterfrom
Open
Conversation
…ithout size limi Incoming webhook bodies are fully buffered with `bl` before parsing JSON, with no explicit maximum size. An attacker can send very large POST bodies to exhaust memory and degrade or crash the process. Affected files: telegramWebHook.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Incoming webhook bodies are fully buffered with
blbefore parsing JSON, with no explicit maximum size. An attacker can send very large POST bodies to exhaust memory and degrade or crash the process.Severity:
highFile:
src/telegramWebHook.jsSolution
Enforce a strict request size limit before buffering (for example via
Content-Lengthchecks and stream byte counting), reject oversized payloads with 413, and set server/request timeouts.Changes
src/telegramWebHook.js(modified)Testing