Skip to content

(Minor) Comment of unit of dilution of precision. It should be unitless #88

Closed
Closed
(Minor) Comment of unit of dilution of precision. It should be unitless#88

Description

@rotorman
rotorman
opened on Jan 18, 2021

Minor problem, but nevertheless it would be nice to have it correct - please check the comment on this line, "dm" seems wrong, as (horizontal) dilution of precision should be unitless:

FrskyTelemetryScript/HORUS/SOURCES/SRC/WIDGETS/Yaapu/main.lua

Line 857 in 82b2245

telemetry.gpsHdopC = bit32.extract(VALUE,7,7) * (10^bit32.extract(VALUE,6,1)) -- dm

Activity

  1. yaapu commented on Jan 20, 2021

    @yaapu
    yaapu
    on Jan 20, 2021
    Owner

    agree, no unit on diluition, thanks

  2. rotorman
    added a commit that references this issue on Jan 29, 2021

    Update main.lua

    601ed07

  3. rotorman commented on Jan 29, 2021

    @rotorman
    rotorman
    on Jan 29, 2021
    Author

    Fixed in a PR #90 that I created.

  4. rotorman
    closed this as completedon Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions