Add prebuilt Docker image#233
Conversation
e7d15bf to
fbaf3f4
Compare
fbaf3f4 to
e9980d7
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9980d7df0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| meta-tags: | | ||
| type=semver,pattern={{version}} |
There was a problem hiding this comment.
These semver tags get pushed without passing the tag into the build. The github-builder workflow only forwards explicit build-args, and its Git context does not provide .git to SwiftPM by default; since Package.swift derives XTOOL_VERSION only from the environment or Git info and xtl_version() falls back to unversioned, every ghcr.io/xtool-org/xtool:<version> image produced here will report xtool unversioned instead of the release version.
Useful? React with 👍 / 👎.
| ADD . /xtool | ||
| RUN ./Linux/build.sh | ||
|
|
||
| FROM swift:6.3 AS xtool |
There was a problem hiding this comment.
Device access regresses for the published image because this final stage starts over from swift:6.3 and never reapplies the USBMUXD_SOCKET_ADDRESS=host.docker.internal:27015 default set in the dev stage. When users run the prebuilt GHCR image with the documented socat forwarding, libusbmuxd falls back to its in-container socket instead of the host forward, so devices/install/launch cannot see attached iOS devices unless every invocation manually passes the env var.
Useful? React with 👍 / 👎.
1 participant
No description provided.