Repository navigation
Fix linux CI and AVX512-128/256 - #1412
Conversation
607bad2 to
483fe3b
Compare
483fe3b to
67292e0
Compare
|
@serge-sans-paille these architectures were not properly tested in CI. |
serge-sans-paille
left a comment
serge-sans-paille
left a comment
There was a problem hiding this comment.
A few questions, but nice work, thanks a lot!
| CMAKE_EXTRA_ARGS="$CMAKE_EXTRA_ARGS -DTARGET_ARCH=knm" | ||
| fi | ||
| if [[ '${{ matrix.sys.flags }}' == 'i386' ]]; then | ||
| CXX_FLAGS="$CXX_FLAGS -m32" |
There was a problem hiding this comment.
that's so error prone, thanks for fixing this.
| else if constexpr (std::is_signed_v<T>) | ||
| { | ||
| auto mask = (other >> (8 * sizeof(T) - 1)); | ||
| auto other_is_negative = other < batch<T, A>(T(0)); |
There was a problem hiding this comment.
This is much more idiomatic
| const uint32_t magic = (0x80 + 0x4000 + 0x200000 + 0x10000000); | ||
|
|
||
| unsigned char res = ((data * magic) >> 24) & 0xFF; | ||
| unsigned char res = (data * magic) >> 28; |
There was a problem hiding this comment.
I feel ashamed. But also very proud of that trick ;-)
There was a problem hiding this comment.
I tend to write all magic numbers as result of constexpr functions. Mostly because I cannot reverse engineer other people magic numbers 😅
|
|
||
| add_subdirectory(doc) | ||
| add_subdirectory(architectures) | ||
| OPTION(BUILD_ARCHITECTURE_TESTS "xsimd compilation tests for various -march targets" OFF) |
There was a problem hiding this comment.
Why didn't you turn this ON by default?
There was a problem hiding this comment.
We can turn this on by default. The current issue is that it does not play well with XSIMD_DEFAULT_ARCH (needed to build avx512_128 etc).
I plan to submit another PR for making it easier to select the architectures so perhaps I'll find a better way there.
Making it the default in the meantime
No description provided.