tvm: fix tvm unrolling - #124
Merged
Merged
Conversation
lfrenot
approved these changes
Sep 2, 2026
lfrenot
left a comment
lfrenot
left a comment
There was a problem hiding this comment.
LGTM, the bug I had on my branch is fixed
guillon
force-pushed
the
dev/cguillon/fix-tvm-unroll
branch
from
September 2, 2026 10:05
4ce6676 to
73bcffc
Compare
guillon
enabled auto-merge
September 2, 2026 10:06
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix a bug introduced in recent refactoring for the support of TVM unroll factor.
Description
Update the
tvm_update_loopnest_for_codegenwhich di not adjust the unrolling if the unrolled dimention was not tiled.Added specific tests for the TVM adjustment of unrolling and vectorization.
Commits
Ref commit.
Discussion
n/a