mlir: extract MlirCpuTarget base for the shared CPU codegen driver - #122
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
guillon
approved these changes
Aug 30, 2026
ElectrikSpace
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MlirLLVMTarget and MlirCTarget carried a ~80%-identical generate_code_for_target (dump-file setup, print_assembly, shared-lib/executable build, cleanup) plus byte-identical helpers (cmd_cc, shared_libs, shared_path, _save_temp, execute_command, ...), differing only in the lower + translate + compile-to-object step.
Description
Hoist the shared driver into a new MlirCpuTarget base as a template method with a _lower_and_compile_object() hook, and move the identical helpers there too. Each CPU target now only implements its own toolchain step (mlir-translate/opt/llc vs xtc-translate/cc).