Add momentum_aperture method to Line class#751
Open
gbrogginess wants to merge 14 commits intoxsuite:mainfrom
Open
Add momentum_aperture method to Line class#751gbrogginess wants to merge 14 commits intoxsuite:mainfrom
momentum_aperture method to Line class#751gbrogginess wants to merge 14 commits intoxsuite:mainfrom
Conversation
giadarol
requested changes
Apr 29, 2026
| multi_element_monitor_at=multi_element_monitor_at, | ||
| **kwargs) | ||
|
|
||
| def momentum_aperture( |
Member
There was a problem hiding this comment.
Rename to get_local_momentum_acceptance
| delta_co= twiss['delta', ee] | ||
|
|
||
| # On-momentum, matched, test particles | ||
| particles = self.build_particles( |
| deltan = float(0.0) | ||
| deltap = float(0.0) | ||
|
|
||
| rows.append({ |
Member
There was a problem hiding this comment.
Add a name as column and use it as index
| s_start: float = 0.0, | ||
| s_end: float | None = None, | ||
| include_name_pattern: str | None = None, | ||
| include_type_pattern: str | None = None, |
Member
There was a problem hiding this comment.
try to reuse Table.rows on twiss table or line table instead of reimplementing
| # Compute twiss (use 6D by default, overridable via kwargs['method']) | ||
| twiss_method = kwargs.pop('method', '6d') | ||
| if twiss is None: | ||
| twiss = self.twiss(method=twiss_method) |
Member
There was a problem hiding this comment.
Pass reverse=False (to avoid surprises form line.twiss.default)
| delta_positive_limit: float = +0.10, | ||
| delta_step_size: float = 0.01, | ||
| skip_elements: int = 0, | ||
| process_elements: int = 2**31 - 1, |
| include_name_pattern: str | None = None, | ||
| include_type_pattern: str | None = None, | ||
| n_turns: int = 512, | ||
| forbid_resonance_crossing: int = 0, |
Member
There was a problem hiding this comment.
Remove, we add it when we have it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new method:
line.momentum_aperture(...)to compute the local momentum aperture (also referred to as local momentum acceptance, LMA) along a beamline by tracking particles with varying momentum offsets from selected elements.
The method evaluates, for each selected longitudinal location, the maximum stable negative and positive momentum deviations (δ) over a configurable number of turns.
For each location, particles are generated around the local closed orbit, a grid of momentum offsets is applied, and particles are tracked to determine the largest surviving negative and positive δ values.
The output is returned as an
xt.Tableindexed by longitudinal positions.This feature is important because the local momentum acceptance is a key quantity for Touschek and quantum lifetime studies and their optimization.
A dedicated test suite covering this new functionality has been added.
Checklist
Mandatory:
Optional: