Fix subprocess exit code checking in Pyxsim to report errors properly#55
Open
xross wants to merge 3 commits into
Open
Fix subprocess exit code checking in Pyxsim to report errors properly#55xross wants to merge 3 commits into
xross wants to merge 3 commits into
Conversation
Previously, subprocess failures in run_with_pyxsim() were silently ignored because the exit code wasn't checked. Now returns False on failure and propagates errors to run_on_simulator_() for proper test failure reporting.
There was a problem hiding this comment.
Pull request overview
This PR improves failure reporting in the Pyxsim test harness by ensuring subprocess/simulator failures are detected and surfaced, rather than being silently ignored.
Changes:
- Capture and propagate subprocess exit codes from the multiprocessing wrapper in
xmostest_subprocess.py, raisingTestErroron non-zero exit. - Make
run_with_pyxsim()return a success boolean and haverun_on_simulator_()fail fast when simulation fails or times out. - Document the behavior change in
CHANGELOG.rst.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/python/Pyxsim/xmostest_subprocess.py | Records subprocess exit codes and raises TestError when commands fail. |
| lib/python/Pyxsim/init.py | Propagates simulator failure/timeout via boolean return values. |
| CHANGELOG.rst | Notes the new exit-code checking behavior under UNRELEASED fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+218
to
+222
| if retval != 0: | ||
| output = "".join(line.decode("utf-8") if isinstance(line, bytes) else line for line in stdout_lines) | ||
| raise TestError( | ||
| f"Command failed with exit code {retval}: {cmd_str}\nOutput:\n{output}" | ||
| ) |
Comment on lines
+276
to
+280
| if retval != 0: | ||
| stdout_str = "".join(line.decode("utf-8") if isinstance(line, bytes) else line for line in stdout_lines) | ||
| stderr_str = "".join(line.decode("utf-8") if isinstance(line, bytes) else line for line in stderr_lines) | ||
| raise TestError( | ||
| f"Command failed with exit code {retval}: {cmd_str}\nStdout:\n{stdout_str}\nStderr:\n{stderr_str}" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
xross
force-pushed
the
fix/subprocess-error-reporting
branch
from
b935bb3 to
983acc5
Compare
Comment on lines
124
to
129
| ev.wait() | ||
| except KeyboardInterrupt: | ||
| pstreekill(process) | ||
| finally: | ||
| process.join() | ||
|
|
Comment on lines
+220
to
+224
| if retval != 0: | ||
| output = "".join(line.decode("utf-8") if isinstance(line, bytes) else line for line in stdout_lines) | ||
| raise TestError( | ||
| f"Command failed with exit code {retval}: {cmd_str}\nOutput:\n{output}" | ||
| ) |
Comment on lines
+279
to
+280
| stdout_str = "".join(line.decode("utf-8") if isinstance(line, bytes) else line for line in stdout_lines) | ||
| stderr_str = "".join(line.decode("utf-8") if isinstance(line, bytes) else line for line in stderr_lines) |
humphrey-xmos
approved these changes
May 22, 2026
humphrey-xmos
left a comment
humphrey-xmos
left a comment
There was a problem hiding this comment.
A useful update. Only a minor comment
| while process[2].is_alive(): | ||
| sys.stdout.write("Waiting for PID %d to terminate\n" % process[2].pid) | ||
| process[2].join(timeout=1.0) | ||
| process[3].terminate() |
There was a problem hiding this comment.
Maybe my lack of understanding, but what is the significance of process[3], rather than process.
Contributor
Author
There was a problem hiding this comment.
process is the entire tuple returned by create_cmd_process
the process object is at index 3 :)
Contributor
Author
There was a problem hiding this comment.
could have been cleaner with a class..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, subprocess failures in run_with_pyxsim() were silently ignored because the exit code wasn't checked. Now returns False on failure and propagates errors to run_on_simulator_() for proper test failure reporting.