feat(chat): find in conversation with ⌘F/Ctrl+F - #764
Open
Jonathan-Asher wants to merge 1 commit into
Open
Jonathan-Asher wants to merge 1 commit into
Jonathan-Asher wants to merge 1 commit into
Conversation
Search the loaded transcript's message prose from the keyboard: ⌘F opens a compact find bar over the thread, Enter/Shift+Enter and arrows walk matches (occurrence-level, capped at 500), Esc closes. The virtualizer jumps to the hit row and the matching message group gets an amber ring. Scoped to the active transcript so background tabs never steal the shortcut; terminal regions decline it (multiplexer chords keep working). Only message text is searched — tool calls, tool results, reasoning traces and chrome are excluded, matching what a reader scans visually. Same loaded-window degradation as the message navigator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds find-in-chat: ⌘F (Ctrl+F on Win/Linux) opens a compact find bar over the open conversation transcript.
Enter/Shift+Enterand the ↑/↓ buttons walk matches; match counter shows "3 of 17";EscclosesscrollToIndex, centered) and the matching message group gets an amber ringworkspace-chrome-controller)Scope note
Searches the loaded transcript window only — the same accepted degradation as the message navigator (paging in older history extends what's findable, and match indices are recomputed per prepend so they never go stale). A follow-up could hook the same extractor into the reverse-infinite-scroll to reach older history on demand.
Testing
message-list-view+virtualized-message-threadsuites pass (49 tests)eslintclean on changed files (incl. React Compiler rules);tscshows only the two pre-existing errors inreasoning.tsx/vitest.config.ts