fix reflect MakeFunc goroutine liveness#1900
Draft
cpunion wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
修复进展(head 根因:失败 job 修复:更新 本地测试:
CI 状态:新 head CI 已触发,目前 checks 仍在 queued/in_progress,我会继续监控并按失败继续修。 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
f5ab3ae to
c072528
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reflect.MakeFunclibffi closure state (closure,Signature, callback data) reachable through the returned function environment.test/gocoverage for reflect-generated functions launched as goroutines under a racingruntime.GCloop.fixedbugs/issue25897a.goxfails.Dependency / merge order
runtime/internal/lib/reflect/makefunc.go: preserve reflect: fix type metadata and MakeFunc results #1916's MakeFunc result validation/storage changes and combine them with this PR's closure/signature lifetime rooting changes.Notes
xgo-dev/llgo.Focused tests
go test ./test/goroot -count=1 -run TestGoRootRunCases -args -goroot /opt/homebrew/Cellar/go@1.24/1.24.11/libexec -dirs fixedbugs -case '^fixedbugs/issue25897a\\.go$' -xfail /tmp/llgo-empty-xfail.yamlgo test ./test/go -run '^TestReflectMakeFuncGoroutineStartup$' -count=1go test ./test/go -count=1go run ./cmd/llgo test -a -run '^TestReflectMakeFuncGoroutineStartup$' ./test/gogo test ./ssa -run '^TestGoClosureStartupUsesGCManagedMemory$' -count=1go test ./ssa -run 'TestGoClosureStartupUsesGCManagedMemory|TestMakeClosureWithCtx|TestClosure' -count=1(cd runtime && go test ./... -count=1)go test ./test/goroot -count=1 -run TestGoRootRunCases -args -goroot /opt/homebrew/Cellar/go@1.24/1.24.11/libexec -dirs fixedbugs -case '^fixedbugs/issue25897a\\.go$' -xfail /tmp/llgo-empty-xfail.yaml -llgo /tmp/llgo-devgo test ./test/goroot -count=1 -run TestGoRootRunCases -args -goroot /opt/homebrew/Cellar/go@1.24/1.24.11/libexec -dirs fixedbugs -case '^fixedbugs/issue25897a\\.go$' -llgo /tmp/llgo-dev