[Piers] bump libde265 to 1.0.16 and libheif to 1.20.2 - #95
Conversation
(cherry picked from commit bafe60a)
|
| --- libheif-1.20.2/libheif/api/libheif/heif_library.h.orig 2025-08-24 12:06:37.536511749 +0200 | ||
| +++ libheif-1.20.2/libheif/api/libheif/heif_library.h 2025-08-24 12:06:50.251187896 +0200 |
There was a problem hiding this comment.
Version-Specific Patch Headers
The refreshed patch embeds the libheif-1.20.2 archive version and generated timestamps instead of using the normalized a/... and b/... format used by sibling patches. This is non-blocking, but it makes future dependency bumps more fragile and requires avoidable manual edits when refreshing the patch.
Knowledge Base Used: Dependency platform patches
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Merged, and I pushed version 22.1.1 to the mirrors |
Port of #79 to
Piers. Fixes #94.On
Piers,depends/common/libheif/flags.txtstill passes-DWITH_LIBDE265=OFF, which it has since the libheif 1.16.1 update. With that flag libheif compiles no HEVC decoder, so every build that takes libheif from these depends (webOS in #94, Windows and Android in #77) fails on every HEIC withDecode error 'Unsupported feature: Unsupported codec'. Builds against a system libheif are not affected, which is why it does not reproduce on most Linux setups.#79 fixed this on
Omega(bump libde265 to 1.0.16 and libheif to 1.20.2,-DWITH_LIBDE265=ON), confirmed on Windows in #77, but it never reachedPiers. On its own it breaks the Windows Store build: libheif 1.20.2 useslseekandunlink, which that toolchain rejects (C4996, the Win64-UWP failure on the first push here, as on #79 itself). #80 fixed that onOmegaa day later, so this PR carries three cherry-picks with their authors kept:-D_CRT_NONSTDC_NO_WARNINGSfor libheif on MSVC, the Windows Store fix.#80's other two commits are left out:
Piersalready has a newer TinyEXIF (#92), and the tinyxml2 bump is unrelated. With that,depends/common/libde265anddepends/common/libheifmatchOmegaexactly. ThePierssource already builds against libheif 1.20.2.How has this been tested?
Built both through Kodi's
cmake/addonson Linux x86_64 (Ubuntu 24.04 container, no system libheif or libde265, so libheif comes from these depends as on webOS), then decoded the two HEIC files attached to #77 with a small libheif program linked against each build's libheif:Paint.heiciPhone13Pro.HEICPiersbeforeWITH_LIBDE265=OFFUnsupported feature: Unsupported codecUnsupported feature: Unsupported codecWITH_LIBDE265=ONThe "before" error is the same line as in the #94 log. The add-on builds and links on both; with this PR libde265 is linked into
imagedecoder.heif.so.Rebuilt after adding the two #80 commits: all libde265 and libheif patches now apply without offset or fuzz, and both files still decode. The Windows Store fix can only be confirmed by the Win64-UWP job here.
Prepared with Claude Code; opened from my account.